Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage of function factory #907

Open
seabbs opened this issue Sep 12, 2024 · 5 comments
Open

coverage of function factory #907

seabbs opened this issue Sep 12, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 12, 2024

As mentioned in hubverse-org/hubEvals#46 do we want to have any kind of special metric function factories for generating things like multiple interval coverages?

I think the answer is potentially with the caveat of do we want a helper across metrics. (i.e duplicate this metric for this arg and the arg input is a vector) or do we want just nicely named special cases.

@seabbs seabbs added the enhancement New feature or request label Sep 12, 2024
@seabbs seabbs self-assigned this Sep 12, 2024
@nikosbosse
Copy link
Contributor

Could be a nice idea

@seabbs
Copy link
Contributor Author

seabbs commented Sep 16, 2024

Any thoughts on implementation questions? I am happy to have a first go at this

@nikosbosse
Copy link
Contributor

nikosbosse commented Sep 16, 2024

My initial thought is that interval coverage is currently the only case that comes to mind where we'd use this. Do you have other cases in mind?

I like the input vector mechanic.

I think it would be cool to make it such that it works nicely with get_metrics - not sure how though.

@nikosbosse
Copy link
Contributor

Aside thoughts:

do we actually want to export select_metrics? It does the same as the exclude and select args.

We had discussed other tools to compose metrics, e.g. selecting only the wis metrics or something like that. O wasn't really clear what that should look like back then. Bumping it up in case it might be relevant here

@seabbs
Copy link
Contributor Author

seabbs commented Sep 16, 2024

My initial thought is that interval coverage is currently the only case that comes to mind where we'd use this. Do you have other cases in mind?

Yes its the only one I can think of as well. We could literally just add add arg to generate new functions to the quantile get_metrics method?

do we actually want to export select_metrics? It does the same as the exclude and select args.

Not sure this is for here but can discuss. I favour keeping it as I prefer the workflow of chaining simple functions vs overloading get_metrics. If anything I would get rid of their internal ability to select...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants