-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage of function factory #907
Comments
Could be a nice idea |
Any thoughts on implementation questions? I am happy to have a first go at this |
My initial thought is that interval coverage is currently the only case that comes to mind where we'd use this. Do you have other cases in mind? I like the input vector mechanic. I think it would be cool to make it such that it works nicely with get_metrics - not sure how though. |
Aside thoughts: do we actually want to export We had discussed other tools to compose metrics, e.g. selecting only the wis metrics or something like that. O wasn't really clear what that should look like back then. Bumping it up in case it might be relevant here |
Yes its the only one I can think of as well. We could literally just add add arg to generate new functions to the quantile get_metrics method?
Not sure this is for here but can discuss. I favour keeping it as I prefer the workflow of chaining simple functions vs overloading get_metrics. If anything I would get rid of their internal ability to select... |
As mentioned in hubverse-org/hubEvals#46 do we want to have any kind of special metric function factories for generating things like multiple interval coverages?
I think the answer is potentially with the caveat of do we want a helper across metrics. (i.e duplicate this metric for this arg and the arg input is a vector) or do we want just nicely named special cases.
The text was updated successfully, but these errors were encountered: