Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_protected_columns() S3 to avoid hard-coding things #889

Open
nikosbosse opened this issue Aug 10, 2024 · 2 comments
Open

Make get_protected_columns() S3 to avoid hard-coding things #889

nikosbosse opened this issue Aug 10, 2024 · 2 comments
Labels
high-priority Should be addressed soon

Comments

@nikosbosse
Copy link
Contributor

          this is another pain point. I guess we could have a s3 method for all classes that lists the protected columns for that ? Are we using this internally anywhere we don't know about the class of the input the user has made? If no we could do this and make this a lot more modular/hard coded

Originally posted by @seabbs in #837 (comment)

@nikosbosse
Copy link
Contributor Author

I'm voting to move this scoringutils version 2.1 (and prioritise it then). It's fair to say that we missed our "first quarter of 2024" deadline by a bit and I'd like to get a first version on CRAN asap

@seabbs
Copy link
Contributor

seabbs commented Sep 12, 2024

Agree though it does block adding more forecast classes in a nice way. If I get time I will look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority Should be addressed soon
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants