-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Popover default color #4329
Labels
BUG
Something isn't working
Comments
jones1008
changed the title
Popover default color should be 'backgroundPrimary
Popover default color should be 'backgroundPrimary'
Jun 20, 2024
jones1008
changed the title
Popover default color should be 'backgroundPrimary'
Remove Popover default color
Jun 20, 2024
Color props have higher priority over CSS variables right now. We're working on an intuitive instrument for CSS variables which is going to resolve this issue. Basically, color prop should become CSS variable. More here: #4261 Right now, you need to prefer color props over css variables. We're not able to calculate text colors, hover colors without js right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Vuestic-ui version: 1.9.11
Description
The default of the prop
color
of the Popover component is currently"#1b1a1f"
as stated here.As you can see in the screenshot, the
background-color: var(--va-popover-content-background-color)
of.va-popover__content
is overwritten by the inline stylebackground-color: #1b1a1
. The CSS variable--va-popover-content-background-color
is defined as--va-background-primary
as you can see here.Optimally the default of the prop
color
should not overwrite this css rule of.va-popover__content
.One possible solution would be to set the default of the prop
color
tobackgroundPrimary
.But maybe it would make more sense to not have a default at all and just get the
background-color
from the CSS rule of.va-popover__content
, and only overwrite it with an inline style, if thecolor
prop is set.Reproduction
Playground Link
The text was updated successfully, but these errors were encountered: