Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain transitions need to be more flexible #22

Open
aaronmondal opened this issue Mar 1, 2023 · 0 comments
Open

Toolchain transitions need to be more flexible #22

aaronmondal opened this issue Mar 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@aaronmondal
Copy link
Contributor

We already use extensive toolchain transitions to handle our various compilation_modes. It looks like this is not enough anymore.

Our current approach is limited in the following ways:

  • We cannot create dynamic libraries in the bootstrap toolchain as linking is not supported there. This means that we can't provide builds for dynamic libc++ and friends.
  • We cannot use ll_binary tools in genrules since that requires the ll_binary to be in exec configuration. We need some way to transition from the compilation_mode-specific target configurations to an exec configuration. This is not supported at the moment.

We need to be careful that opening the toolchains up to handle such cases only leads to excessive rebuilds when absolutely necessary. Otherwise users may end up building LLVM several times just to get a trivial ll_binary working in a genrule. We may also need better platform support to tackle this elegantly.

Things work at the moment because we can fall back to rules_cc for exec tools. This is a very undesirable limitation of the current implementation.

@aaronmondal aaronmondal added the enhancement New feature or request label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant