Skip to content

Disable DataflowAnalysis pass by default #12919

@JaroslavTulach

Description

@JaroslavTulach

Motivation

Why do we need DataflowAnalysis Anyway?

  • I performed an experiment to disable DataflowAnalysis
  • by commenting out body of runModule and runExpression methods
  • runEngineDistribution --run test/Base_Tests continues to pass!
  • only runtime-integration-tests/testOnly *Runtime*Test fail
  • morever the Base.bindings cache shrinked from 36MB to 26MB!

Only for Interactive Sources

  • Looks like DataflowAnalysis is only needed for interactive sources
  • e.g. sources processed by runtime-instrument* modules

Goal

  • disable DataflowAnalysis for non-interactive sources
  • only compute it when IdExecutionInstrument (or co.) needs it
  • make sure benchmarks are sped up
    • write new benchmark to mimic interactive use
  • make sure caches are smaller

Metadata

Metadata

Labels

Type

No type

Projects

Status

⚙️ Design

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions