New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression update should contain full multi-value info #12153

Open

4e6 opened this issue Jan 27, 2025 · 6 comments · May be fixed by #12195

Assignees

Labels

-gui -language-server

Contributor

4e6 commented Jan 27, 2025 •

edited by JaroslavTulach

Loading

The EnsoMutliValue was updated to carry dispatch and extra sets of types.

enso/engine/runtime/src/main/java/org/enso/interpreter/runtime/data/EnsoMultiValue.java

Lines 42 to 45 in d960676

    
           public final class EnsoMultiValue extends EnsoObject { 
        
             private final EnsoMultiType dispatch; 
        
             private final EnsoMultiType extra; 
        
             private final int firstDispatch;

The ExpressionUpdate message returns only a union of dispatch and extra set of types of a multi-value (aka intersection type)

interface ExpressionUpdate {
  /** The id of updated expression. */
  expressionId: ExpressionId;
  /** The updated type of the expression.
   *
   *  Possible values:
   *  - empty array indicates no type information for this expression
   *  - array with a single value contains a value of this expression
   *  - array with multiple values represents an intersetion type
   */
  type: string[];
  /** The updated method call info. */
  methodCall?: MethodCall;
  /** Profiling information about the expression. */
  profilingInfo: ProfilingInfo[];
  /** Whether the expression's value came from the cache. */
  fromCache: boolean;
  /** An extra information about the computed value. */
  payload: ExpressionUpdatePayload;
}

The ExpressionUpdate type information needs to be updated to carry the extra set of types of the multi-value and allow the IDE to find out what are the dispatch types and what are the extra types.

The text was updated successfully, but these errors were encountered:

4e6 added -gui -language-server labels

4e6 self-assigned this

github-project-automation bot added this to Issues Board

github-project-automation bot moved this to ❓New in Issues Board

4e6 moved this from ❓New to 📤 Backlog in Issues Board

Member

JaroslavTulach commented Jan 28, 2025

FYI: #11600 (comment)

4e6 moved this from 📤 Backlog to 🔧 Implementation in Issues Board

enso-bot bot commented Jan 29, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-01-27):

Progress: [cloud-v2][1651] Discussed possible implementations of the synchronization logic. Confirmed the short-term plan with the gui team. Started implementing the upload logic as a part of the project-manager shim middleware. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

enso-bot bot commented Jan 29, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-01-28):

Progress: [cloud-v2][1651] Discussed downloading logic with Pavel. Negotiated a new API. Finished implementing the upload logic of the gui RemoteBackend. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

enso-bot bot commented Jan 29, 2025

Dmitry Bushev reports a new STANDUP for today (2025-01-29):

Progress: [cloud-v2][1651] Implemented the upload handling in the gui project-manager middleware. Implemented the enso-project bundle creation. [12153] Implemented a new TypeInfo type representation as it is observed from the execution instrument. Starting updating the instrumentation logic It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

4e6 linked a pull request

that will close this issue

Expression update contains full multi-value info #12195

Draft

5 tasks

JaroslavTulach mentioned this issue

Intersection types & type checks #11600

Merged

4 tasks

enso-bot bot commented Jan 31, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-01-30):

Progress: [cloud-v2][1651] Added menu uption to run the cloud project locally. Implemented rough logic for downloading the project and spawning the local project manager. [12153] Updated the instrumentation logic. Started working on fixing the tests. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

enso-bot bot commented Jan 31, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-01-31):

Progress: [9976] Investigated the issue of failing uploads. Started moving the run script upload logic to the github actions upload-artifact. Updated the Engine and IDE workflows. Created a draft PR. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment