Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a Table that has just 1 column to act as Column #12137

Closed
radeusgd opened this issue Jan 24, 2025 · 3 comments · Fixed by #12165
Closed

Allow a Table that has just 1 column to act as Column #12137

radeusgd opened this issue Jan 24, 2025 · 3 comments · Fixed by #12165
Assignees
@radeusgd
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request

Comments

@radeusgd
Copy link
Member

Next step in intersection types work in Libraries.

We want to refine the Table type with & Column iff. table.columns.length == 1.

This should work for both Table and DB_Table (the latter is refined with & DB_Column).
@radeusgd radeusgd added the -libs Libraries: New libraries to be implemented label Jan 24, 2025
@radeusgd radeusgd self-assigned this Jan 24, 2025
@radeusgd radeusgd added the x-new-feature Type: new feature request label Jan 24, 2025
@radeusgd radeusgd moved this from ❓New to 🔧 Implementation in Issues Board Jan 24, 2025
@enso-bot enso-bot bot mentioned this issue Jan 27, 2025
Closed
@enso-bot
Copy link

enso-bot bot commented Jan 28, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-01-27):

Progress: Merged single-value column PR. Created prototype for single-column Table. Fighting with some weird IR bug. It should be finished by 2025-01-29.

Next Day: Next day I will be working on the same task. Finish the second PR, work on signatures PR.

@radeusgd radeusgd mentioned this issue Jan 28, 2025
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jan 29, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-01-28):

Progress: After discussion rewriting the PR to have more code duplication based on current limitations. Fighting with bugs. It should be finished by 2025-01-29.

Next Day: Next day I will be working on the same task. Finish the second PR, work on signatures PR.

@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 29, 2025
@enso-bot
Copy link

enso-bot bot commented Feb 3, 2025

Radosław Waśko reports a new STANDUP for the provided date (2025-01-29):

Progress: Continuing with single-column Table PR, investigating and reporting several issues related to intersection types, trying for find workarounds to still move forward with the PR. It should be finished by 2025-01-29.

Next Day: Next day I will be working on the #12186 task. Start next tasks.

@mergify mergify bot closed this as completed in #12165 Feb 4, 2025
mergify bot pushed a commit that referenced this issue Feb 4, 2025
@radeusgd
Refine single-column Table to act as a Column (#12165)
7031afe 
- Closes #12137
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request
Projects
Issues Board
Status: 🟢 Accepted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine single-column Table to act as a Column enso-org/enso
1 participant
@radeusgd