Database IR

[GregoryTravis]

Agenda

• Rename IR types
• Other IR changes
• Names instead of numbers in Base_Generator.generate_select_query_sql
• Identify operations with constructors instead of strings

Rename IR types

Straw man suggestion:

• SQL_Expression -> SQL_Column
• From_Spec -> SQL_From_Part
• Context -> SQL_IR_Table
• Query -> SQL_Statement

Names instead of numbers in Base_Generator.generate_select_query_sql

Give them constructor names, but optionally keep numbers for ordering:

            builder.append [Select_100, SQL_Builder.code "SELECT "]
            builder.append [Columns_200, generated_columns]
            builder.append [From_300, SQL_Builder.code " FROM " ++ from_part]
            builder.append [Where_400, where_part]
            builder.append [Group_500, group_part]
            builder.append [Order_600, order_part]
            builder.append [Limit_700, limit_part]

Identify operations with constructors instead of strings

[GregoryTravis]

#12122

[GregoryTravis]

Conclusion:

• SQL_Expression -> AST_Expression
• From_Spec -> AST_From_Part
• Context -> AST_Table
• Query -> AST_Statement

[JaroslavTulach]

Overloading term AST when there is Truffle Framework around used in the same repository - which is itself is a tool for Building Self-Optimizing AST Interpreters - is just asking for confusion.

I'd say: sorry, the term AST is already taken. Choose something else.