Skip to content

Commit cd8011b

Browse files
committed
Redshift does not suport Supports_Nested_With_Clause
1 parent 45804b3 commit cd8011b

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

distribution/lib/Standard/AWS/0.0.0-dev/src/Database/Redshift/Internal/Redshift_Dialect.enso

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,7 @@ type Redshift_Dialect
259259
Dialect_Flag.Primary_Key_Allows_Nulls -> False
260260
## TODO: Check if Redshift supports NaN
261261
Dialect_Flag.Supports_Separate_NaN -> False
262-
## TODO: Check if Redshift supports WITH clauses in nested queries
263-
Dialect_Flag.Supports_Nested_With_Clause -> True
262+
Dialect_Flag.Supports_Nested_With_Clause -> False
264263
Dialect_Flag.Supports_Case_Sensitive_Columns -> False
265264
Dialect_Flag.Supports_Infinity -> True
266265
Dialect_Flag.Case_Sensitive_Text_Comparison -> True

test/Table_Tests/src/Database/Common/IR_Spec.enso

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,12 @@ add_specs (suite_builder : Suite_Builder) setup (prefix : Text) default_connecti
7272
count_nodes a . should_be_a Integer
7373
count_nodes b . should_be_a Integer
7474
count_nodes c . should_be_a Integer
75+
76+
does_not_support_nested_with_clause =
77+
if data.connection.dialect.flagged ..Supports_Nested_With_Clause then Nothing else
78+
"Does not suport nested with clause"
7579

76-
group_builder.specify "let bindings should not affect the end result" <|
80+
group_builder.specify "let bindings should not affect the end result" pending=does_not_support_nested_with_clause <|
7781
t = table_builder [["x", [1.3, 2.8]], ["y", [-3.4, 7.2]]]
7882
x = t.at "x"
7983
y = t.at "y"
@@ -90,10 +94,6 @@ add_specs (suite_builder : Suite_Builder) setup (prefix : Text) default_connecti
9094
big.to_vector
9195
results.flatten.flatten.flatten.distinct.length . should_equal 1
9296

93-
does_not_support_nested_with_clause =
94-
if data.connection.dialect.flagged ..Supports_Nested_With_Clause then Nothing else
95-
"Does not suport nested with clause"
96-
9797
group_builder.specify "should convert WITH binders to short names that do not conflict with existing table names" pending=does_not_support_nested_with_clause <|
9898
t = Table.new [["x", [1, 2]], ["y", ['a', 'b']]]
9999
let0 = t.select_into_database_table data.connection "let_0" temporary=True

0 commit comments

Comments
 (0)