Fix files drag-and-drop (#13548)

Fixes #13535

The Electron API has changed.

Author: vitvakatu

app/gui/env.d.ts

@@ -85,6 +85,7 @@ interface DownloadUrlOptions {
 interface SystemApi {
   readonly downloadURL: (options: DownloadUrlOptions) => Promise<void>
   readonly showItemInFolder: (fullPath: string) => void
+  readonly getFilePath: (item: File) => string
 }
 
 /** Metadata for a newly imported project. */

app/gui/src/dashboard/services/LocalBackend.ts

@@ -732,26 +732,17 @@ export default class LocalBackend extends Backend {
     } else {
       const title = backend.stripProjectExtension(body.fileName)
       let id: string
-      if (
-        'backendApi' in window &&
-        // This non-standard property is defined in Electron.
-        'path' in file &&
-        typeof file.path === 'string' &&
-        file.path !== ''
-      ) {
-        const projectInfo = await window.backendApi.importProjectFromPath(
-          file.path,
-          parentPath,
-          title,
-        )
+      const path = window.systemApi?.getFilePath(file)
+      if ('backendApi' in window && path != null) {
+        const projectInfo = await window.backendApi.importProjectFromPath(path, parentPath, title)
         id = projectInfo.id
       } else {
         const searchParams = new URLSearchParams({
           directory: parentPath,
           name: title,
         }).toString()
-        const path = `/api/upload-project?${searchParams}`
-        const response = await fetch(path, { method: 'POST', body: file })
+        const url = `/api/upload-project?${searchParams}`
+        const response = await fetch(url, { method: 'POST', body: file })
         id = await response.text()
       }
       const projectId = newProjectId(projectManager.UUID(id), parentPath)

app/gui/src/project-view/components/GraphEditor/upload.ts

@@ -56,6 +56,7 @@ export class Uploader {
       awareness: Awareness
     },
     private file: File,
+    private filePath: string | undefined,
     private position: Vec2,
     private isOnLocalBackend: boolean,
     private disableDirectRead: boolean,
@@ -81,7 +82,16 @@ export class Uploader {
     disableDirectRead: boolean,
     method: ExternalId,
   ): Uploader {
-    return new Uploader(projectStore, file, position, isOnLocalBackend, disableDirectRead, method)
+    const filePath = window.systemApi?.getFilePath(file)
+    return new Uploader(
+      projectStore,
+      file,
+      filePath,
+      position,
+      isOnLocalBackend,
+      disableDirectRead,
+      method,
+    )
   }
 
   private progressUpdate(sizePercentage: number) {
@@ -95,13 +105,8 @@ export class Uploader {
   /** Start the upload process */
   async upload(): Promise<Result<UploadResult>> {
     // This non-standard property is defined in Electron.
-    if (
-      this.isOnLocalBackend &&
-      !this.disableDirectRead &&
-      'path' in this.file &&
-      typeof this.file.path === 'string'
-    ) {
-      return Ok({ source: 'FileSystemRoot', name: this.file.path })
+    if (this.isOnLocalBackend && !this.disableDirectRead && this.filePath != null) {
+      return Ok({ source: 'FileSystemRoot', name: this.filePath })
     }
     const rootId = await this.projectFiles.projectRootId
     if (rootId == null) return Err('Could not identify project root.')

app/ide-desktop/client/src/globals.d.ts

@@ -106,6 +106,7 @@ export type DownloadUrlOptions = {
 interface SystemApi {
   readonly downloadURL: (options: DownloadUrlOptions) => Promise<void>
   readonly showItemInFolder: (fullPath: string) => void
+  readonly getFilePath: (item: File) => string
 }
 
 // ========================

app/ide-desktop/client/src/preload.ts

@@ -203,6 +203,9 @@ exposeInMainWorld(SYSTEM_API_KEY, {
   showItemInFolder: (fullPath: string) => {
     electron.ipcRenderer.send(ipc.Channel.showItemInFolder, fullPath)
   },
+  getFilePath: (item: File) => {
+    return electron.webUtils.getPathForFile(item)
+  },
 })
 
 // ====================