Fix defects.

Author: jdunkerley

distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Java_Problems.enso

@@ -11,9 +11,9 @@ from project.Internal.Storage import java_to_enso
 
 polyglot java import org.enso.table.data.column.builder.LossOfBigDecimalPrecision
 polyglot java import org.enso.table.data.column.builder.LossOfIntegerPrecision
-polyglot java import org.enso.table.data.column.operation.cast.CastOperation
 polyglot java import org.enso.table.data.column.operation.cast.ConversionFailure
 polyglot java import org.enso.table.data.column.operation.cast.ConversionFailureType
+polyglot java import org.enso.table.data.column.storage.type.StorageType
 polyglot java import org.enso.table.data.table.problems.ArithmeticError
 polyglot java import org.enso.table.data.table.problems.ArithmeticOverflow
 polyglot java import org.enso.table.data.table.problems.FloatingPointGrouping
@@ -57,15 +57,15 @@ translate_problem p = case p.problemType of
     "LossOfBigDecimalPrecision" ->
         Loss_Of_Decimal_Precision.Warning p.getAffectedRowsCount (java_to_enso p.getExampleValue) p.getExampleValueConverted
     "ArithmeticOverflow" ->
-        storage_type = CastOperation.makeLocalType p.targetType
+        storage_type = StorageType.fromTypeCharAndSize p.targetTypeChar p.targetTypeSize
         target_type = Storage.to_value_type storage_type
         example_operands = case p.exampleOperands of
             Nothing -> Nothing
             array -> Vector.from_polyglot_array array
         Arithmetic_Overflow.Warning target_type p.affectedRowCount example_operands
     "ConversionFailure" ->
         examples = Vector.from_polyglot_array p.examples
-        storage_type = CastOperation.makeLocalType p.targetType
+        storage_type = StorageType.fromTypeCharAndSize p.targetTypeChar p.targetTypeSize
         target_type = Storage.to_value_type storage_type
         related_column = p.relatedColumn
         affected_rows_count = p.affectedRowCount

std-bits/table/src/main/java/org/enso/table/data/column/operation/cast/CastProblemAggregator.java

@@ -54,7 +54,8 @@ public ProblemSummary summarize() {
       problems.add(
           new ConversionFailure(
               ConversionFailureType.FAILED_CONVERSION,
-              targetType,
+              targetType.typeChar(),
+              targetType.size(),
               columnName,
               failedConversionsCount,
               failedConversionExamples));
@@ -64,7 +65,8 @@ public ProblemSummary summarize() {
       problems.add(
           new ConversionFailure(
               ConversionFailureType.NUMBER_OUT_OF_RANGE,
-              targetType,
+              targetType.typeChar(),
+              targetType.size(),
               columnName,
               numberOutOfRangeCount,
               numberOutOfRangeExamples));
@@ -74,7 +76,8 @@ public ProblemSummary summarize() {
       problems.add(
           new ConversionFailure(
               ConversionFailureType.TEXT_TOO_LONG,
-              targetType,
+              targetType.typeChar(),
+              targetType.size(),
               columnName,
               textTooLongCount,
               textTooLongExamples));

std-bits/table/src/main/java/org/enso/table/data/column/operation/cast/ConversionFailure.java

@@ -1,12 +1,12 @@
 package org.enso.table.data.column.operation.cast;
 
 import java.util.List;
-import org.enso.table.data.column.storage.type.StorageType;
 import org.enso.table.problems.Problem;
 
 public record ConversionFailure(
     ConversionFailureType errorType,
-    StorageType<?> targetType,
+    char targetTypeChar,
+    long targetTypeSize,
     String relatedColumn,
     long affectedRowCount,
     List<?> examples)

std-bits/table/src/main/java/org/enso/table/data/table/Table.java

@@ -580,10 +580,9 @@ public static Table transpose(
     int new_count = size * to_transpose.length;
 
     // Create Storage
-    var storage =
-        Arrays.stream(id_columns)
-            .map(c -> c.getStorageType().makeBuilder(new_count, problemAggregator))
-            .toArray(Builder[]::new);
+    var storage = new Builder[id_columns.length + 2];
+    IntStream.range(0, id_columns.length)
+        .forEach(i -> id_columns[i].getStorageType().makeBuilder(new_count, problemAggregator));
     storage[id_columns.length] = Builder.getForText(TextType.VARIABLE_LENGTH, new_count);
     storage[id_columns.length + 1] = Builder.getInferredBuilder(new_count, problemAggregator);
 

std-bits/table/src/main/java/org/enso/table/data/table/problems/ArithmeticOverflow.java

@@ -1,9 +1,8 @@
 package org.enso.table.data.table.problems;
 
-import org.enso.table.data.column.storage.type.StorageType;
 import org.enso.table.problems.Problem;
 
 /** Indicates that an arithmetic operation did not fit in the target type. */
 public record ArithmeticOverflow(
-    StorageType<?> targetType, long affectedRowCount, Object[] exampleOperands)
+    char targetTypeChar, long targetTypeSize, long affectedRowCount, Object[] exampleOperands)
     implements Problem {}

std-bits/table/src/main/java/org/enso/table/data/table/problems/MapOperationProblemAggregator.java

@@ -49,7 +49,12 @@ public void reportDivisionByZero(long row) {
   public ProblemSummary summarize() {
     var summary = super.summarize();
     if (overflowCount > 0) {
-      summary.add(new ArithmeticOverflow(overflowTargetType, overflowCount, overflowExample));
+      summary.add(
+          new ArithmeticOverflow(
+              overflowTargetType.typeChar(),
+              overflowTargetType.size(),
+              overflowCount,
+              overflowExample));
     }
     return summary;
   }