Update analysis_options.yaml

Author: enm10k

analysis_options.yaml

@@ -18,6 +18,7 @@ linter:
     # - avoid_types_on_closure_parameters
     - cascade_invocations
     - combinators_ordering
+    - constant_identifier_names
     - directives_ordering
     - discarded_futures
     - empty_statements
@@ -27,7 +28,7 @@ linter:
     - prefer_conditional_assignment
     - prefer_contains
     - prefer_expression_function_bodies
-    - prefer_final_parameters # avoid_final_parameters
+    - avoid_final_parameters # prefer_final_parameters
     - prefer_final_in_for_each
     - prefer_final_locals
     - prefer_if_elements_to_conditional_expressions

integration_test/hello_test.dart

@@ -12,9 +12,9 @@ const NC_PASS = String.fromEnvironment('NC_PASS');
 
 // https://github.com/flutter/flutter/issues/88765#issuecomment-1113140289
 Future<void> waitFor(
-  final WidgetTester tester,
-  final Finder finder, {
-  final Duration timeout = const Duration(seconds: 20),
+  WidgetTester tester,
+  Finder finder, {
+  Duration timeout = const Duration(seconds: 20),
 }) async {
   final end = DateTime.now().add(timeout);
 
@@ -32,7 +32,7 @@ void main() {
   HttpOverrides.global = null;
   IntegrationTestWidgetsFlutterBinding.ensureInitialized();
 
-  testWidgets('sign in', (final WidgetTester tester) async {
+  testWidgets('sign in', (WidgetTester tester) async {
     await tester.pumpWidget(
       const ProviderScope(
         child: App(),

lib/common/components/not_implementing_dialog.dart

@@ -7,8 +7,7 @@ class NotImplementedDialog extends HookConsumerWidget {
   });
 
   @override
-  Widget build(final BuildContext context, final WidgetRef ref) =>
-      const AlertDialog(
+  Widget build(BuildContext context, WidgetRef ref) => const AlertDialog(
         title: Text('Not implemented'),
         content: Text('...'),
       );

lib/common/components/scroll_detector.dart

@@ -11,9 +11,8 @@ class ScrollDetector extends HookConsumerWidget {
   final Future<void> Function()? onEnd;
 
   @override
-  Widget build(final BuildContext context, final WidgetRef ref) =>
-      NotificationListener(
-        onNotification: (final ScrollEndNotification n) {
+  Widget build(BuildContext context, WidgetRef ref) => NotificationListener(
+        onNotification: (ScrollEndNotification n) {
           if (n.metrics.axis != Axis.vertical) {
             return true;
           }

lib/common/components/single_value_dialog.dart

@@ -14,7 +14,7 @@ class SingleValueDialog extends HookConsumerWidget {
   final List<Widget> actions;
 
   @override
-  Widget build(final BuildContext context, final WidgetRef ref) {
+  Widget build(BuildContext context, WidgetRef ref) {
     final textEditController = useTextEditingController(text: '');
 
     return AlertDialog(

lib/common/extensions.dart

@@ -16,7 +16,7 @@ extension StringExtension on String {
 
 extension JsonListExtension on Iterable<Map<String, dynamic>> {
   Map<String, dynamic> flatten() => reduce(
-        (final a, final b) {
+        (a, b) {
           a.addAll(b);
           return a;
         },

lib/common/flash_wrapper.dart

@@ -8,8 +8,8 @@ const _successDuration = Duration(seconds: 1);
 const _errorDuration = Duration(seconds: 3);
 
 notifySuccess(
-  final BuildContext context, {
-  required final String message,
+  BuildContext context, {
+  required String message,
 }) async {
   await context.showSuccessBar(
     position: FlashPosition.top,
@@ -20,9 +20,9 @@ notifySuccess(
 
 // TODO: Change to dialog?
 notifyError(
-  final BuildContext context,
-  final dynamic error,
-  final StackTrace? stackTrace,
+  BuildContext context,
+  dynamic error,
+  StackTrace? stackTrace,
 ) async {
   logger.warning(error);
   if (stackTrace != null) {

lib/common/logger.dart

@@ -4,7 +4,7 @@ import 'package:simple_logger/simple_logger.dart';
 const debugLogLevel = Level.FINER;
 
 final logger = SimpleLogger()
-  ..formatter = ((final info) => '[${info.level}] '
+  ..formatter = ((info) => '[${info.level}] '
       // '${DateFormat('HH:mm:ss.SSS').format(info.time)} '
       // '[${info.callerFrame ?? 'caller info not available'}] '
       '[${info.callerFrame?.library ?? '-'}:${info.callerFrame?.line}] '
@@ -13,7 +13,7 @@ final logger = SimpleLogger()
     kReleaseMode ? Level.OFF : debugLogLevel,
     includeCallerInfo: true,
   )
-  ..onLogged = (final log, final info) {
+  ..onLogged = (log, info) {
     // if (info.level >= Level.SEVERE) {
     //   throw AssertionError('Stopped by logger');
     // }

lib/common/preferences.dart

@@ -19,7 +19,7 @@ class Preferences {
   }
 
   Future<T?> get<T>({
-    required final String key,
+    required String key,
   }) async {
     dynamic v;
     switch (T) {
@@ -49,14 +49,14 @@ class Preferences {
   }
 
   Future<String?> getSecure({
-    required final String key,
+    required String key,
   }) async =>
       await _secureStorage.read(key: key);
 
   Future<void> set({
-    required final String key,
-    required final dynamic value,
-    final bool secure = false,
+    required String key,
+    required dynamic value,
+    bool secure = false,
   }) async {
     if (value == null) {
       return;

lib/common/settings.dart

@@ -9,21 +9,21 @@ final settings = Settings();
 class Settings {
   Preferences? prefs;
   bool get initialized => prefs != null;
-  init(final Preferences prefs) {
+  init(Preferences prefs) {
     this.prefs = prefs;
   }
 
   static const _authToken = 'authToken';
   Future<String?> get authToken async =>
       await prefs?.getSecure(key: _authToken);
 
-  Future<void> setAuthToken(final String v) async =>
+  Future<void> setAuthToken(String v) async =>
       await prefs?.set(key: _authToken, value: v, secure: true);
 
   static const _email = 'email';
   Future<String?> get email async => await prefs?.get(key: _email);
 
-  Future<void> setEmail(final String v) async => await prefs?.set(
+  Future<void> setEmail(String v) async => await prefs?.set(
         key: _email,
         value: v,
       );
@@ -37,13 +37,13 @@ class Settings {
     return v;
   }
 
-  Future<void> setApiBaseUrl(final String v) async =>
+  Future<void> setApiBaseUrl(String v) async =>
       await prefs?.set(key: _apiBaseUrl, value: v);
 
   static const _rememberMe = 'rememberMe';
   Future<bool> get rememberMe async =>
       await prefs?.get<bool>(key: _rememberMe) ?? false;
-  Future<void> setRememberMe(final bool v) async => await prefs?.set(
+  Future<void> setRememberMe(bool v) async => await prefs?.set(
         key: _rememberMe,
         value: v,
       );