Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter normalization/key hashing #8

Open
2 tasks
engisalor opened this issue Mar 1, 2023 · 0 comments
Open
2 tasks

Improve parameter normalization/key hashing #8

engisalor opened this issue Mar 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@engisalor
Copy link
Owner

Custom key creation and parameter dict normalization here can be improved.

These functions are in part necessary due to a requests-cache issue. It's been addressed and this topic should be reassessed after the fix is included in its next release (1.0.0?).

While the requests-cache fix will improve URL handling, a custom key creation function is likely still needed to fully account for how Sketch Engine GET requests work. E.g., normalizing CQL strings will reduce functionally equivalent API calls.

  • The simplest but most pervasive issue is stripping unnecessary spaces: alemma, "sandwich" == alemma,"sandwich".
  • Requires a suite of tests to ensure that changes to normalization avoid unwanted side effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant