fix(ses): fix #2951 stronger sniffing for v8

Author: erights

packages/ses/src/error/tame-error-constructor.js

@@ -7,6 +7,7 @@ import {
   getOwnPropertyDescriptor,
   defineProperty,
   getOwnPropertyDescriptors,
+  isArray,
 } from '../commons.js';
 import { NativeErrors } from '../permits.js';
 import { tameV8ErrorConstructor } from './tame-v8-error-constructor.js';
@@ -37,9 +38,44 @@ export default function tameErrorConstructor(
 ) {
   const ErrorPrototype = FERAL_ERROR.prototype;
 
-  const { captureStackTrace: originalCaptureStackTrace } = FERAL_ERROR;
-  const platform =
-    typeof originalCaptureStackTrace === 'function' ? 'v8' : 'unknown';
+  const {
+    captureStackTrace: originalCaptureStackTrace,
+    prepareStackTrace: originalPrepareStackTrace,
+  } = FERAL_ERROR;
+  let platform = 'unknown';
+  if (typeof originalCaptureStackTrace === 'function') {
+    // we might be on v8
+    if (typeof originalPrepareStackTrace === 'function') {
+      // This case should not occur on v8 or any other platform.
+      // But if it does, we assume we're on v8, or a platform whose
+      // error stack logic is close enough that we can treat it
+      // like v8.
+      platform = 'v8';
+    } else {
+      try {
+        FERAL_ERROR.prepareStackTrace = (error, sst) => {
+          // eslint-disable-next-line no-use-before-define
+          if (error === sacrificialError && isArray(sst)) {
+            // v8 implements `prepareStackTrace`. But on v8 the initial state
+            // of the original error constructor, `FERAL_ERROR`, has no
+            // `prepareStackTrace` property. To test whether the current
+            // platform implements it,
+            // we must set our own and then see if `error.stack` triggers it.
+            // If so, then we assume we're on v8, or a platform whose
+            // error stack logic is close enough that we can treat it
+            // like v8.
+            platform = 'v8';
+          }
+        };
+        const sacrificialError = new FERAL_ERROR('just for testing');
+        // Intentionally accesses `sacrificialError.stack` only to trigger
+        // the test `prepareStackTrace` for platform detection.
+        sacrificialError.stack;
+      } finally {
+        delete FERAL_ERROR.prepareStackTrace;
+      }
+    }
+  }
 
   const makeErrorConstructor = (_ = {}) => {
     // eslint-disable-next-line no-shadow