Consider warning caller if supplied client params will in favour of transport
#3134
Unanswered
declension
asked this question in
Potential Issue
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
First of all, thanks for a great library!
I recently got surprised when debugging something to find that if you do:
You won't get cert config
trust_env
respected (but yourbase_url
will be)I agree that the precedence logic (
transport
overriding params) probably makes sense, but it feels risky to take these parameters, some of which set up important security features, and silently ignore them if another parameter is supplied.It seems some others have been surprised here (See #2888, #2513 (comment))
Note also this might probably come into focus more now, with the deprecation of
app=app
method of setting up a client (this is how we got to creating a transport manually).Perhaps a warning of some sort might help here?
Beta Was this translation helpful? Give feedback.
All reactions