Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socks proxy should support read/write timeouts #862

Open
Anthonybelui opened this issue Dec 22, 2023 Discussed in #859 · 1 comment
Open

Socks proxy should support read/write timeouts #862

Anthonybelui opened this issue Dec 22, 2023 Discussed in #859 · 1 comment

Comments

@Anthonybelui
Copy link

Discussed in #859

Originally posted by Anthonybelui December 16, 2023
Hello, thanks for developing the library.
I wanted to ask you to fix/define the logic for the read timeout in socks_proxy. This creates an infinity reading.

File httpcore/_sync/socks_proxy.py
Function _init_socks5_connection()
Line: incoming_bytes = stream.read(max_bytes=4096) > incoming_bytes = stream.read(max_bytes=4096, timeout=SomeTimeout)

@iamdrq
Copy link

iamdrq commented Jan 8, 2024

I opened a PR fixed this:
#868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants