New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7722. #7882

Open

tbrknt wants to merge 2 commits into encode:master from tbrknt:fix-null-boolean-rendering-7722

Contributor

tbrknt commented Mar 29, 2021

Render BooleanFields with allow_null=True as HTML select rather than as
HTML checkbox in Browsable API #7722.

Description

This PR is created in order to fix issue #7722. A serializer field of type BooleanField with allow_null=True was being rendered as HTML checkbox elements on Browsable API forms even though three values (True, False, and None/null) are possible. It was also happening for the model BooleanField instances with allow_null=True that are converted to serializer BooleanField instances. In this PR, I worked on keeping the checkbox rendering for BooleanFields with allow_null=False while providing dropdown rendering (HTML select element) for BooleanFields with allow_null=True.

fix #7722
refs #7722

Member

tomchristie commented Mar 29, 2021

Thanks for working on this. Having a look over, I'm wondering about the alternative of not introducing a new template, and using the existing "select.html" template.


Fix encode#7722.

5c9bd01

Render BooleanFields with allow_null=True as HTML select rather than as
HTML checkbox in Browsable API encode#7722.

tbrknt force-pushed the fix-null-boolean-rendering-7722 branch from 5e2b339 to 5c9bd01 Compare

March 29, 2021 14:38

Contributor Author

tbrknt commented Mar 29, 2021

Hi @tomchristie ,
Thank you for your comment. I was thinking about that alternative too. The following part from select.html was my main hesitation to use it. I was not sure if I should adapt the value of BooleanField and that part of the template. Without changing that template, I could not think of a solution to drop -------- and introduce unknown option. What do you think about it?
If unknown option is not that important, I believe it is possible to make the value of the BoundField as 'False' string instead of False boolean value. That way, for False, we can avoid if not field.value.

  <select class="form-control" name="{{ field.name }}">
    {% if field.allow_null or field.allow_blank %}
      <option value="" {% if not field.value %}selected{% endif %}>--------</option>
    {% endif %}
  </select>

stale bot commented Apr 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

auvipy requested changes

View reviewed changes

Member

auvipy left a comment

can you please rebase and make it merge able again, please

rest_framework/templates/rest_framework/horizontal/select_boolean.html Outdated Show resolved Hide resolved

stale bot removed stale labels

stale bot commented Jan 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

auvipy removed the stale label


Update rest_framework/templates/rest_framework/horizontal/select_bool…

51f3113

…ean.html

Contributor

merwok commented Jan 21, 2023

Could the PR title have some words in it to describe the bug or the fix? Would help all of us looking at notifications or lists of tickets. Thanks!

stale bot commented Mar 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added stale and removed stale labels

stale bot commented Jun 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added stale and removed stale labels

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added stale and removed stale labels

Member

auvipy commented Aug 13, 2023

we might need a new taker for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment