Merge pull request honestbleeps#2588 from erikdesjardins/gulp-qunit

Run QUnit tests in Gulp

Author: kevinji

README.md

@@ -116,7 +116,7 @@ Sass (`.scss`) files in `lib/` will be compiled with [Sass](http://sass-lang.com
 
 **`gulp <tasks> -b chrome -b firefox`** can be used with any of the above commands to specify individual browsers (chrome, firefox, safari), instead of performing the task(s) for all of them.
 
-**`gulp travis`** will verify the code style (and point out any errors) of all `.js` files in `lib/` (except `lib/vendor/`) using [ESLint](http://eslint.org/), as well as all `.scss` files with [scss-lint](https://github.com/brigade/scss-lint). We recommend that you run this before opening a pull request. (This is used by Travis CI to automatically test pull requests.)
+**`gulp travis`** will verify the code style (and point out any errors) of all `.js` files in `lib/` (except `lib/vendor/`) using [ESLint](http://eslint.org/), as well as all `.scss` files with [scss-lint](https://github.com/brigade/scss-lint). It will also run QUnit tests (in `tests/qunit`). We recommend that you run this before opening a pull request. (This is used by Travis CI to automatically test pull requests.)
 
 Note: You will need to install [Ruby](https://www.ruby-lang.org/) and run `gem install scss_lint` before using `gulp travis`.
 

gulpfile.babel.js

@@ -14,6 +14,7 @@ import plumber from 'gulp-plumber';
 import sourcemaps from 'gulp-sourcemaps';
 import eslint from 'gulp-eslint';
 import scsslint from 'gulp-scss-lint';
+import qunit from 'gulp-qunit';
 import through from 'through-gulp';
 
 const options = require('minimist')(process.argv.slice(2));
@@ -94,6 +95,15 @@ const browserConf = {
 			root: 'node',
 			baseSources: 'lib'
 		}
+	},
+	qunit: {
+		sources: [
+			{ cwd: 'tests/qunit/**', src: '*.*' }
+		],
+		dests: {
+			root: 'qunit',
+			baseSources: '/'
+		}
 	}
 };
 
@@ -184,12 +194,14 @@ gulp.task('copy-browser', () =>
 
 gulp.task('manifests', () =>
 	merge(
-		browsers.map(browser =>
-			gulp.src(browserConf[browser].manifest || ['*', '!*'])
-				.pipe(cache('manifests'))
-				.pipe(through.map(file => populateManifest(browser, file)))
-				.pipe(dest(getBuildDir(browser)))
-		)
+		browsers
+			.filter(browser => browserConf[browser].manifest)
+			.map(browser =>
+				gulp.src(browserConf[browser].manifest)
+					.pipe(cache('manifests'))
+					.pipe(through.map(file => populateManifest(browser, file)))
+					.pipe(dest(getBuildDir(browser)))
+			)
 	)
 );
 
@@ -219,13 +231,19 @@ function populateManifest(browser, file) {
 // Add new modules to browser manifests
 gulp.task('add-module', () =>
 	merge(
-		browsers.map(browser => addModuleToManifest(browserConf[browser].filesList || browserConf[browser].manifest))
+		browsers
+			.map(browser => browserConf[browser].filesList || browserConf[browser].manifest)
+			.filter(manifest => manifest)
+			.map(manifest => addModuleToManifest(manifest))
 	)
 );
 
 gulp.task('add-host', () =>
 	merge(
-		browsers.map(browser => addHostToManifest(browserConf[browser].filesList || browserConf[browser].manifest))
+		browsers
+			.map(browser => browserConf[browser].filesList || browserConf[browser].manifest)
+			.filter(manifest => manifest)
+			.map(manifest => addHostToManifest(manifest))
 	)
 );
 
@@ -267,7 +285,7 @@ gulp.task('zip', () => {
 	);
 });
 
-gulp.task('travis', ['eslint', 'scsslint']);
+gulp.task('travis', ['eslint', 'scsslint', 'qunit']);
 
 gulp.task('eslint', () =>
 	src(baseConf.sources.babel)
@@ -281,3 +299,9 @@ gulp.task('scsslint', () =>
 		.pipe(scsslint({ maxBuffer: 1024 * 1024 }))
 		.pipe(scsslint.failReporter())
 );
+
+// todo: when Gulp 4 is released, only build qunit
+gulp.task('qunit', ['build'], () =>
+	gulp.src('dist/qunit/tests.html')
+		.pipe(qunit())
+);

package.json

@@ -22,6 +22,7 @@
     "gulp-cached": "^1.1.0",
     "gulp-eslint": "^1.1.0",
     "gulp-plumber": "^1.0.0",
+    "gulp-qunit": "^1.3.0",
     "gulp-replace": "^0.5.4",
     "gulp-sass": "^2.1.1",
     "gulp-scss-lint": "^0.3.8",

tests/qunit/tests.html

@@ -7,11 +7,10 @@
 </head>
 <body>
   <div id="qunit"></div>
-  <div id="qunit-fixture"></div>  
+  <div id="qunit-fixture"></div>
 
-  <script src="../../lib/vendor/jquery-1.11.3.min.js"></script>
-  <script src="../../lib/reddit_enhancement_suite.user.js"></script>
-  <script src="../../lib/core/utils.js"></script>
+  <script src="vendor/jquery-1.11.3.min.js"></script>
+  <script src="core/utils.js"></script>
   <script src="../../node_modules/qunitjs/qunit/qunit.js"></script>
 
   <script src="test-escapeHTML.js"></script>