Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all meta stuff #51

Open
amyrlam opened this issue Mar 25, 2021 · 2 comments
Open

Test all meta stuff #51

amyrlam opened this issue Mar 25, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@amyrlam
Copy link
Member

amyrlam commented Mar 25, 2021

From Learning Team meeting with @mansona @locks @jaredgalanis

ember-learn/guides-source#1647 meta stuff wasn't working in guides-source. We should audit that it's working and potentially fix the tests here in guidemaker repo.
@amyrlam amyrlam mentioned this issue Mar 25, 2021
Merged
@amyrlam
Copy link
Member Author

amyrlam commented Mar 25, 2021

cc @ijlee2 from convo on the related guides-source PR ember-learn/guides-source#1647

@mansona
Copy link
Member

mansona commented Mar 26, 2021

https://github.com/empress/empress-blog/blob/master/tests/acceptance/meta-test.js is a great example of the sorts of tests that we should expect for Guidemaker 👍

@mansona mansona added good first issue Good for newcomers and removed help wanted labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mansona @amyrlam