-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch for json needs to respect rootURL #13
Comments
We've chatted about this in Discord but I'm going to put a summary of our discussion here for others to see 👍 Right now most Empress projects don't support being deployed in a sub-folder, for exactly the reason that you're seeing. Sure you can change the Some deep thought needs to go into this to make sure that it covers all of the expected use cases. We need to come up with some scenarios (like deploying to github pages that requires a subfolder, or a lightning deployment strategy that has static files on a different host to the index.html using prefix) and make sure that we solve this problem in a general enough way that all Empress projects can share the solution 👍 It's a complex problem but if we keep the goal of the feature in mind I am confident that we can come up with a reasonably straight-forward solution that is flexible enough to cover every use case (possibly with a bit of extra config) |
I've changed the
rootURL
property of config as I'm deploying my docs under some nested directory of the server. Sincefield-guide
generates variousjson
file configs for the docs, we may need to respect therootURL
config while fetching these JSONs. Otherwise, thefield-guide
will try to fetch these JSONs from the root of the server which leads to 404The text was updated successfully, but these errors were encountered: