-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix numerOfPages
typo
#63
Comments
🙃 I have a feeling that very few people will be using this because pagination is not really documented in empress-blog anywhere. But yes, if we do fix this then we need to use a computed property or something that will throw a deprecation warning 👍 |
I’ll have to check my own usages to be sure 😂 |
empress-blog/addon/controllers/index.js
Line 23 in ec92c91
Seems like this will be a breaking change. Could also implement the typo version as an alias + deprecation warning.
The text was updated successfully, but these errors were encountered: