Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numerOfPages typo #63

Open
nickschot opened this issue Jun 11, 2020 · 2 comments
Open

Fix numerOfPages typo #63

nickschot opened this issue Jun 11, 2020 · 2 comments

Comments

@nickschot
Copy link
Contributor

numerOfPages: computed('model.links.last', function() {

Seems like this will be a breaking change. Could also implement the typo version as an alias + deprecation warning.

@mansona
Copy link
Member

mansona commented Jun 12, 2020

🙃 I have a feeling that very few people will be using this because pagination is not really documented in empress-blog anywhere. But yes, if we do fix this then we need to use a computed property or something that will throw a deprecation warning 👍

@nickschot
Copy link
Contributor Author

🙃 I have a feeling that very few people will be using this because pagination is not really documented in empress-blog anywhere. But yes, if we do fix this then we need to use a computed property or something that will throw a deprecation warning 👍

I’ll have to check my own usages to be sure 😂

@stavares843 stavares843 mentioned this issue Jun 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants