-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] the canonical url is not being built correctly #144
Labels
good first issue
Good for newcomers
Comments
Is this still happening? The images on your personal blog seem to be working find… 🤔 |
So there is a chance that this was fixed when I fixed this #145 but I would like to be 100% sure before closing this issue. It looks like the canonical on the ember blog is still broken so maybe it just needs an update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is something strange going on with the canonical URL for posts. There is a test that should be covering this https://github.com/empress/empress-blog/blob/master/tests/acceptance/meta-test.js#L40-L41 but if you look at the source of https://blog.emberjs.com/the-ember-times-issue-190/ the canonical should be
https://blog.emberjs.com/the-ember-times-issue-190/
but it's actuallyhttps://blog.emberjs.comthe-ember-times-issue-190/
. This isn't just for the ember blog it seems to be every deployment: https://chris.manson.ie/it's-all-gravy has the same issueThe text was updated successfully, but these errors were encountered: