-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Correct benchmark result + joseph-md5 #42
Comments
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that in your README, there is a benchmark testing, but the joseph's md5 is not included. I wonder which is faster so I tried to compare it.
Docs for joseph-md5: https://www.myersdaily.org/joseph/javascript/md5-text.html
Benchmark 1
Benchmark: https://measurethat.net/Benchmarks/Show/29171/0/md5-performance-comparison-v2
Result:
Benchmark 2
https://measurethat.net/Benchmarks/Show/29172/0/md5-performance-comparison-long-text-v2
Result:
Issue with the current benchmark in README
jsperf.app
is a bit unreliable on short time self execution. It should be tested with a long input.deferred.resolve
is required.Correct
jsperf.app
withdeferred.resolve
+joseph-md5
Benchmark: https://jsperf.app/jonuhi/6
Now it comes out the result that aligns with
measurethat.net
.Summary
Your library is great ! I believe it is the fastest MD5 library for sync md5 function.
I will submit a PR for updating the README :)
Note: I guess if you convert
js-md5
to using low-level WebAssembly coding, it will be much faster.The text was updated successfully, but these errors were encountered: