Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-vaul-no-drag on parent element not working with input fields #320

Open
Poylar opened this issue Apr 9, 2024 · 6 comments
Open

data-vaul-no-drag on parent element not working with input fields #320

Poylar opened this issue Apr 9, 2024 · 6 comments

Comments

@Poylar
Copy link

Poylar commented Apr 9, 2024

its about this issue #267
this solution still not working with input field.if you place data-vaul-no-drag on input element it work fine, but this not work when parent element has data-vaul-no-drag attribute
I've reproduced it here
link

@maiconcarraro
Copy link
Sponsor

@Poylar pretty sure the fix wasnt part of the release 0.9.0, they should release soon together w/ other fixes

@lucarampi
Copy link

I have a similar issue. I am using MonacoEditor/react. When I drag to select the text inside it the drawer slides together. I inspected and noticed that all the lines inside the Monaco Editor are

tags. Even if I wrap arroud a
around the Monaco Editor it still sliding.

Shoudn`t it not drag the Vaul if a parent of it is with "data-vaul-no-drag" ?

@maiconcarraro
Copy link
Sponsor

maiconcarraro commented Apr 9, 2024

Shoudn`t it not drag the Vaul if a parent of it is with "data-vaul-no-drag" ?

@lucarampi there is a merged fix for this #267

We are only waiting for a new release bump

@lucarampi
Copy link

Im sorry, now I see. I though #267 was on 0.9 already, My bad.

@maiconcarraro is there some release date in your mind? So I can keep checking for updates;

@maiconcarraro
Copy link
Sponsor

@lucarampi I'm not a maintainer, I mean "we" as part of the people that are waiting for the next release, I noticed Emil merged a few PRs days ago, hopefully it's going to be soon

@franzwilhelm
Copy link

Opened an issue to bump npm version: #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants