Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for iOS PWA app bar #269

Open
keeganpotgieter opened this issue Feb 15, 2024 · 3 comments · May be fixed by #274
Open

Add support for iOS PWA app bar #269

keeganpotgieter opened this issue Feb 15, 2024 · 3 comments · May be fixed by #274

Comments

@keeganpotgieter
Copy link
Contributor

keeganpotgieter commented Feb 15, 2024 •
edited

Add the ability to match the colour of the iOS PWA application bar to the overlay colour to create a more native feel.

Examples

Without iOS App Bar Support

With iOS App Bar Support

Solution

  • User needs these meta tags
    • <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" />
    • <meta name="apple-mobile-web-app-capable" content="yes" />
  • Changes made in vaul/src/index.tsx to dynamically change the background colour to match overlay background colour
  • Will also solve some of the issues with this issue Why does shouldScaleBackground add a black background to the body? #259
@keeganpotgieter keeganpotgieter linked a pull request Feb 17, 2024 that will close this issue
Open
@Dearest
Copy link

Dearest commented Feb 18, 2024

Cool, this is exactly what I need.

@Dearest
Copy link

Dearest commented Feb 18, 2024

maybe， can solve this issue #199 too

@keeganpotgieter
Copy link
Contributor Author

maybe， can solve this issue #199 too

It seems like #199 isn't an issue with body backgrounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve ios web app styling keeganpotgieter/vaul
2 participants
@Dearest @keeganpotgieter