Make sure plot size is positive #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
requested changes
May 10, 2024
| @@ -105,7 +105,10 @@ impl super::View for ContextMenus { | |||
| .speed(1.0) | |||
| .prefix("Height: "), | |||
| ); | |||
| self.width = self.width.at_least(1.0); | |||
| self.height = self.height.at_least(1.0); | |||
There was a problem hiding this comment.
use DragValue::clamp_range instead
emilk
reviewed
May 11, 2024
crates/egui_plot/src/lib.rs
Outdated
Comment on lines
771
to
773
| // Minimum values for screen protection | ||
| min_size.x = min_size.x.at_least(64.0); | ||
| min_size.y = min_size.y.at_least(15.0); |
There was a problem hiding this comment.
I don't think we should do this. If the user wants a plot that is 16x32 pixels big, let them have it
There was a problem hiding this comment.
I don't think we should do this. If the user wants a plot that is
16x32pixels big, let them have it
If it is greater than 1.0, panic does not occur, so it was set to 1.0.
If you want to edit it to a different size, please do so.
emilk
changed the title
emilk
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: in Plot, Minimum values for screen protection.