Skip to content

Commit 158fdd7

Browse files
committed
Work on CI builds
1 parent fffb15e commit 158fdd7

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

CMakeLists.txt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -265,22 +265,22 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Android")
265265
target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE Qt::CorePrivate)
266266
endif()
267267

268-
if(APPLE)
269-
set(CMAKE_XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER "com.emeric.watchflower.ios")
270-
set(CMAKE_XCODE_ATTRIBUTE_MARKETING_VERSION "${PROJECT_VERSION}")
271-
272-
set(CMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED "NO")
273-
set(CMAKE_XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY "")
274-
set(CMAKE_XCODE_ATTRIBUTE_DEVELOPMENT_TEAM "")
275-
set(CMAKE_XCODE_ATTRIBUTE_PROVISIONING_PROFILE "")
276-
endif()
277-
278268
## macOS
279269
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
280270
#set(CMAKE_OSX_ARCHITECTURES "x86_64;arm64")
281271
set(CMAKE_OSX_DEPLOYMENT_TARGET "11.0")
282-
set(CMAKE_XCODE_ATTRIBUTE_INFOPLIST_FILE "${CMAKE_CURRENT_SOURCE_DIR}/assets/macos/Info.plist")
283-
set(CMAKE_XCODE_ATTRIBUTE_CODE_SIGN_ENTITLEMENTS "${CMAKE_CURRENT_SOURCE_DIR}/assets/macos/${CMAKE_PROJECT_NAME}.entitlements")
272+
set(UTILS_DOCK_ENABLED true)
273+
274+
set_target_properties(${CMAKE_PROJECT_NAME} PROPERTIES
275+
MACOSX_BUNDLE ON
276+
MACOSX_BUNDLE_INFO_PLIST "${CMAKE_SOURCE_DIR}/assets/macos/Info.plist"
277+
# New Xcode attributes (???)
278+
XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER "io.emeric.watchflower"
279+
XCODE_ATTRIBUTE_PRODUCT_NAME ${CMAKE_PROJECT_NAME}
280+
XCODE_ATTRIBUTE_CURRENT_PROJECT_VERSION ${CMAKE_PROJECT_VERSION}
281+
XCODE_ATTRIBUTE_MARKETING_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}
282+
XCODE_ATTRIBUTE_CODE_SIGN_ENTITLEMENTS "${CMAKE_SOURCE_DIR}/assets/macos/${CMAKE_PROJECT_NAME}.entitlements"
283+
)
284284
endif()
285285

286286
## iOS

assets/ios/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
<string>WatchFlower</string>
1616

1717
<key>CFBundleExecutable</key>
18-
<string>$(EXECUTABLE_NAME)</string>
18+
<string>WatchFlower</string>
1919

2020
<key>CFBundleIdentifier</key>
21-
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
21+
<string>com.emeric.watchflower.ios</string>
2222

2323
<key>CFBundleVersion</key>
2424
<string>0600001</string>

assets/macos/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
<string>WatchFlower</string>
1616

1717
<key>CFBundleExecutable</key>
18-
<string>$(EXECUTABLE_NAME)</string>
18+
<string>WatchFlower</string>
1919

2020
<key>CFBundleIdentifier</key>
21-
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
21+
<string>io.emeric.watchflower</string>
2222

2323
<key>CFBundleVersion</key>
2424
<string>0600001</string>

0 commit comments

Comments
 (0)