-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary files at local disk should be deleted when embulk job is aborted #70
Comments
MEMO: embulk itself does not have any plugin hook points to be called on signal handler. Writing something in To handle Ctrl-C, Of course, we should not catch signal in our plugin because it breaks entire Java work load. |
Fixed in #140. Please feel free to reopen the issue if you have any concerns. |
When I abort embulk job with Ctrl+C, temporary files at local disk wasn't removed.
I think we should imprement content of abort() at embulk-output-bigquery/lib/embulk/output/bigquery.rb L525 or https://github.com/embulk/embulk-output-bigquery/blob/master/lib/embulk/output/bigquery.rb#L423
The text was updated successfully, but these errors were encountered: