Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary files at local disk should be deleted when embulk job is aborted #70

Closed
chie8842 opened this issue May 5, 2017 · 2 comments
Closed

Comments

@chie8842
Copy link

chie8842 commented May 5, 2017

When I abort embulk job with Ctrl+C, temporary files at local disk wasn't removed.
I think we should imprement content of abort() at embulk-output-bigquery/lib/embulk/output/bigquery.rb L525 or https://github.com/embulk/embulk-output-bigquery/blob/master/lib/embulk/output/bigquery.rb#L423

@sonots
Copy link
Member

sonots commented Aug 10, 2019

MEMO: embulk itself does not have any plugin hook points to be called on signal handler. Writing something indef abort or else does not work.

To handle Ctrl-C, Runtime.addShutdownHook() can be used in Java. In the case of JRuby, it becomes like https://gist.github.com/hiremaga/320008.

Of course, we should not catch signal in our plugin because it breaks entire Java work load.

@hiroyuki-sato
Copy link
Contributor

Fixed in #140. Please feel free to reopen the issue if you have any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants