Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a11y test over deprecation-app #81

Open
serenaf opened this issue Feb 18, 2018 · 2 comments
Open

Run a11y test over deprecation-app #81

serenaf opened this issue Feb 18, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@serenaf
Copy link
Collaborator

serenaf commented Feb 18, 2018

See ember-learn/guides-app#46 as example and follow ;)

@serenaf serenaf added good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers labels Mar 3, 2018
@takshch
Copy link

takshch commented Nov 24, 2020

This issue is too old. Is this issue still exits?
If yes, assign me to this issue.

@ijlee2
Copy link
Member

ijlee2 commented Nov 24, 2020

Hi, @takshch. Thanks for taking an interest in helping out. I think it's a good idea to audit accessibility in tests. However, there are currently 2 soft-blocking issues.

One, installing ember-a11y-testing v4 will result in an error,

ember-a11y-testing has the following unmet peerDependencies:
  * @ember/test-helpers: `^2.0.0`; it was resolved to `1.7.2`

because ember-qunit v4.6 still uses version 1.x of @ember/test-helpers. We could install v3.x of ember-a11y-testing to see how much work will be needed in fixing a11y issues (when visiting the pages listed in https://github.com/ember-learn/deprecation-app/blob/master/tests/acceptance/visual-regression-test.js#L10).

Two, the app may be redesigned some time in the future so the work that you may put into may be gone. If there's a lot of work needed in fixing a11y issues, I think it may not be a good idea to make big changes to the app right now.

Before we decide whether to continue with this issue, I'd like to hear what your thoughts are on these two matters. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants