Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Router Events" deprecation guide #1034

Open
Tracked by #1711
locks opened this issue Dec 16, 2021 · 2 comments
Open
Tracked by #1711

Update "Router Events" deprecation guide #1034

locks opened this issue Dec 16, 2021 · 2 comments

Comments

@locks
Copy link
Contributor

locks commented Dec 16, 2021

The following guide https://deprecations.emberjs.com/v3.x/#toc_deprecate-router-events uses Route#transitionTo–which is now deprecated–in the "after" code sample. Should this be updated to use the Router service? The "Router Events" deprecation is 20 minor versions earlier, but I believe the Router service was already available, and it skip triggering one deprecation if we show examples with the Router service.

@jenweber
Copy link
Contributor

jenweber commented Dec 16, 2021

One way to tackle this is to run the example through the octane codemod and see what happens, instead of rewriting by hand.

Since this deprecation was introduced in 3.4, prior to Octane, and is removed for 4.0, we want to show both styles of examples - one that works pre-Octane, and one that works after.

@kategengler
Copy link
Contributor

The willTransition and didTransition that are removed were on the Router class https://deprecations.emberjs.com/v3.x/#toc_deprecate-router-events

The deprecation guide for the until 5.0 deprecation is https://deprecations.emberjs.com/v3.x/#toc_routing-transition-methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants