Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More edgecases :D #67

Closed
alexander-alvarez opened this issue Nov 14, 2017 · 1 comment
Closed

More edgecases :D #67

alexander-alvarez opened this issue Nov 14, 2017 · 1 comment

Comments

@alexander-alvarez
Copy link
Contributor

alexander-alvarez commented Nov 14, 2017

Just wanted to give some context as to the barrage of PRs and issues.
Ran the codemod against my repo and came up with these edge cases (#63, #64, #65, #66).

I found that in describing issues, I might have well simply added testcases, so instead of opening issues where I knew the expected outcome, I wrote failing testcases and opened PRs (with the hope that someone may get to them quicker than I)

Thanks for the great codemod. I'll likely eventually get to them, but more than happy to see them magically go away 😃

@rwjblue
Copy link
Member

rwjblue commented Nov 17, 2017

Tracking individual issues separately so I'm going to close this issue for now...

@rwjblue rwjblue closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants