-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop RSVP dependency #2051
Labels
Comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
rsvp
dependency should not be needed anymore. It was primarily a polyfill for nativePromise
. All modern browsers support nativePromise
these days. We can simplify our code base and prepare for planned deprecation by removing the dependency.@NullVoxPopuli started the work in #1875 but doesn't have the time to finish it.
RSVP is not used at many places. GitHub code search lists 11 places.
Main priority should be on code shipped to end user. This affects 3 places:
transitionEnd
utility function (addon/utils/transition-end.js
)<BsForm>
component (addon/components/bs-form.js
)blueprints/ember-bootstrap/index.js
)rsvp
as a dependency rather than a dev dependency.The other 7 places affects only code, which is not shipped to consumers:
In most cases the transition should be fairly simple.
RSVP.Promise
,RSVP.reject
, andRSVP.resolve
can be replaced with their native equivalents. OnlyRSVP.defer
does not have a native equivalent. But it could be replaced by an utility function, which I sketched here: #1875 (comment)The text was updated successfully, but these errors were encountered: