Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to enable lexical-binding and improve evil-delay #1685

Open
monnier opened this issue Sep 30, 2022 · 6 comments · May be fixed by #1693
Open

Patch to enable lexical-binding and improve evil-delay #1685

monnier opened this issue Sep 30, 2022 · 6 comments · May be fixed by #1693

Comments

@monnier
Copy link
Contributor

monnier commented Sep 30, 2022

I pushed to the scratch/evil branch of nongnu.git a patch which enables lexical-binding in all the files and replaces the evil-delay function (which has to work via the awful eval) with an evil-with-delay macro which lets the byte-compiler properly see and compile the code.

@tomdl89
Copy link
Member

tomdl89 commented Oct 1, 2022

Cool, sounds interesting. What URL do I git clone?

@monnier
Copy link
Contributor Author

monnier commented Oct 1, 2022 via email

@tomdl89
Copy link
Member

tomdl89 commented Oct 4, 2022

@monnier are you sure that branch is there/accessible? I get

Cloning into 'elpa'...
warning: Could not find remote branch scratch/evil to clone.
fatal: Remote branch scratch/evil not found in upstream origin

@monnier
Copy link
Contributor Author

monnier commented Oct 4, 2022 via email

@tomdl89 tomdl89 linked a pull request Oct 5, 2022 that will close this issue
@tomdl89
Copy link
Member

tomdl89 commented Oct 5, 2022

I've brought this in as a branch on evil and opened a PR, linked. You'll see there are 3 failed tests. Please take a look when convenient - I'm not sure I'll have the time for a while. Cheers

@monnier
Copy link
Contributor Author

monnier commented Oct 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants