-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging with "tar.exe" on Windows #50
Comments
Eldev now supports Windows, but I personally don't use it and don't even have access to it. Maybe @juergenhoetzel or @ikappaki, who actually added Windows support, can help. Maybe we could just try using non-absolute filename for the target ( By the way, it is better not to use |
Hi @dominiksta, It appears your are picking the tar executable that comes bundled with your git installation:
which does not understand drive letters. Can you jingle your PATH env variable to pick up the tar version instead that comes with Windows 10 at If you call Thanks |
The root cause of the problem is the fact that
I you don't want to customize your system (setf eldev-tar-executable "C:/Windows/system32/tar.exe") |
Oh wow I was not aware that Windows ships with a tar executable. I thought I had to use some third party tool like Git Bash or Cygwin to have a tar executable. The suggested included executable works! Thank you. For other potential users like me, would it maybe make sense to include a word or two about this in the documentation? Alternatively, would it not make some sense to change the definition of (defun eldev-tar-executable (&optional not-required)
"Find `tar' executable.
See also variable `eldev-tar-executable'."
(eldev-find-executable
eldev-tar-executable not-required
(if (eq system-type 'windows-nt) "C:/Windows/System32/tar.exe"
(or (executable-find "gtar") (executable-find "tar")))
"Cannot find `tar' program")) |
Even better would be to write it in
I'd say it is a bug in GNU
It feels rather pointless, I doubt anyone will search for this in documentation.
Feels a bit backwards, there is system variable We can probably just use
It will theoretically not always be enough because of |
I guess its a feature. GNU-Info
which can be disabled:
It's pretty useless these days and it leads to many problems under windows nowadays: package-build--create-tar: don't fiddle with windows filenames |
Gah, what a mess. I guess reporting is pointless then, even if the supposed feature is stupid when "USER" is omitted and "HOST" consists of a single letter (i.e. just a normal Windows path). Anyway, I will accept practically any improvement/workaround for Eldev (e.g. using relative path after |
How about we introduce a new
Happy to start by implementing something for the case at hand. |
Sounds interesting, but would be nice to have at least 3-5 problems it could find, and preferably not only Windows-specific. Also, if you start this, please create a separate file, e.g. By the way, proposal from my last comment still holds. I just don't want to do it myself, as I don't even have access to Windows. |
Great, I will consider it. Although I'm might not be able to find 3-5 problems to include as a starting point, I could perhaps include some diagnostics information (eldev/emacs version build/project artifacats) that could be useful for users to include in their issue reports. Would this perhaps be enough for an initial release?
I am more of the opinion that we should default tar to Thanks! |
Would be an improvement, but still I'd like to see at least one generally (i.e. not just Windows) useful item from the start. As an idea, have a look through closed issues, maybe also those that are not bugs, but e.g. misconfigurations. Maybe you could detect some of those.
Sorry, no. I feel like if someone put something on your |
Hi,
I am trying out Eldev for the first time and I am really liking it so far. However, I think I may have stumbled upon a bug when trying to create a tarball on windows - meaning I cannot build a package.
Here is the output of
eldev -vt package
:What seems to be happening is that "tar.exe" does not like dealing with paths prefixed with c:/ or generally any drive letter. At least this simple test command from powershell implies this:
I have tested this with the "tar.exe" from both cygwin and git bash - they both show the same error. Theoretically, it should absolutely be possible to build a package from wsl, but this is an inconvenience for someone like me who primarily uses native Windows tooling (please don't bully me ;) ).
The text was updated successfully, but these errors were encountered: