Build failure with emacs 30

[kurnevsky]

It happens when I try to build lsp-origami, but it looks like the root cause is origami-fold-header-face:

emacs-lsp-origami> Compiling /nix/store/x1iggzf256c280qp2964gsmgv1bnqsxw-emacs-lsp-origami-20230815.704/share/emacs/site-lisp/elpa/lsp-origami-20230815.704/lsp-origami.el...
emacs-lsp-origami> Error: error ("Invalid face box" :line-width 1 :color unspecified)
emacs-lsp-origami>   set-face-attribute(origami-fold-header-face #<frame F1 0xd3e6e0> :box (:line-width 1 :color unspecified) :background unspecified)
emacs-lsp-origami>   face-spec-set-2(origami-fold-header-face #<frame F1 0xd3e6e0> (:box (:line-width 1 :color unspecified) :background unspecified))
emacs-lsp-origami>   face-spec-recalc(origami-fold-header-face #<frame F1 0xd3e6e0>)
emacs-lsp-origami>   face-spec-set(origami-fold-header-face ((t (:box (:line-width 1 :color unspecified) :background unspecified))) face-defface-spec)
emacs-lsp-origami>   custom-declare-face(origami-fold-header-face ((t (:box (:line-width 1 :color unspecified) :background unspecified))) "Face used to display fold headers." :group origami)
emacs-lsp-origami>   require(origami)
emacs-lsp-origami>   byte-compile-file-form-require((require 'origami))
emacs-lsp-origami>   byte-compile-file-form((require 'origami))
emacs-lsp-origami>   #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_50>((require 'origami))
emacs-lsp-origami>   byte-compile-recurse-toplevel((require 'origami) #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_50>)
emacs-lsp-origami>   byte-compile-toplevel-file-form((require 'origami))
emacs-lsp-origami>   #f(compiled-function () #<bytecode 0xaa3d790c7be623>)()
emacs-lsp-origami>   bytecomp--displaying-warnings(#f(compiled-function () #<bytecode 0xaa3d790c7be623>))
emacs-lsp-origami>   byte-compile-from-buffer(#<buffer  *Compiler Input*>)
emacs-lsp-origami>   byte-compile-file("/nix/store/x1iggzf256c280qp2964gsmgv1bnqsxw-emacs-lsp-origami-20230815.704/share/emacs/site-lisp/elpa/lsp-origami-20230815.704/lsp-origami.el")
emacs-lsp-origami>   byte-recompile-file("/nix/store/x1iggzf256c280qp2964gsmgv1bnqsxw-emacs-lsp-origami-20230815.704/share/emacs/site-lisp/elpa/lsp-origami-20230815.704/lsp-origami.el" t 0)
emacs-lsp-origami>   #f(compiled-function () #<bytecode 0x1679791aa2d1bb4f>)()
emacs-lsp-origami>   bytecomp--displaying-warnings(#f(compiled-function () #<bytecode 0x1679791aa2d1bb4f>))
emacs-lsp-origami>   byte-recompile-directory("/nix/store/x1iggzf256c280qp2964gsmgv1bnqsxw-emacs-lsp-origami-20230815.704/share/emacs/site-lisp/elpa/lsp-origami-20230815.704" 0 t)
emacs-lsp-origami>   package--compile(#s(package-desc :name lsp-origami :version (20230815 704) :summary "origami.el support for lsp-mode" :reqs ((emacs (27 1)) (origami (1 0)) (lsp-mode (6 1))) :kind nil :archive nil :dir "/nix/store/x1iggzf256c280qp2964gsmgv1bnqsxw-emacs-lsp-origami-20230815.704/share/emacs/site-lisp/elpa/lsp-origami-20230815.704" :extras ((:url . "https://github.com/emacs-lsp/lsp-origami") (:keywords "languages" "lsp-mode")) :signed nil))
emacs-lsp-origami>   package-unpack(#s(package-desc :name lsp-origami :version (20230815 704) :summary "origami.el support for lsp-mode" :reqs ((emacs (27 1)) (origami (1 0)) (lsp-mode (6 1))) :kind single :archive nil :dir nil :extras ((:keywords "languages" "lsp-mode") (:url . "https://github.com/emacs-lsp/lsp-origami")) :signed nil))
emacs-lsp-origami>   (let ((pkg-desc (if (derived-mode-p 'tar-mode) (package-tar-file-info) (package-buffer-info)))) (package-unpack pkg-desc) pkg-desc)
emacs-lsp-origami>   elpa2nix-install-from-buffer()
emacs-lsp-origami>   (progn (if is-tar (insert-file-contents-literally file) (insert-file-contents file)) (if is-tar (progn (tar-mode))) (elpa2nix-install-from-buffer))
emacs-lsp-origami>   (unwind-protect (progn (if is-tar (insert-file-contents-literally file) (insert-file-contents file)) (if is-tar (progn (tar-mode))) (elpa2nix-install-from-buffer)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))
emacs-lsp-origami>   (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if is-tar (insert-file-contents-literally file) (insert-file-contents file)) (if is-tar (progn (tar-mode))) (elpa2nix-install-from-buffer)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
emacs-lsp-origami>   (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if is-tar (insert-file-contents-literally file) (insert-file-contents file)) (if is-tar (progn (tar-mode))) (elpa2nix-install-from-buffer)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))
emacs-lsp-origami>   (let ((is-tar (string-match "\\.tar\\'" file))) (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (if is-tar (insert-file-contents-literally file) (insert-file-contents file)) (if is-tar (progn (tar-mode))) (elpa2nix-install-from-buffer)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))))
emacs-lsp-origami>   elpa2nix-install-file("/build/packages/lsp-origami-20230815.704.el")
emacs-lsp-origami>   (progn (setq package-user-dir elpa) (elpa2nix-install-file archive))
emacs-lsp-origami>   (let ((archive x0) (elpa x2)) (progn (setq package-user-dir elpa) (elpa2nix-install-file archive)))
emacs-lsp-origami>   (if (null x3) (let ((archive x0) (elpa x2)) (progn (setq package-user-dir elpa) (elpa2nix-install-file archive))))
emacs-lsp-origami>   (let* ((x2 (car-safe x1)) (x3 (cdr-safe x1))) (if (null x3) (let ((archive x0) (elpa x2)) (progn (setq package-user-dir elpa) (elpa2nix-install-file archive)))))
emacs-lsp-origami>   (if (consp x1) (let* ((x2 (car-safe x1)) (x3 (cdr-safe x1))) (if (null x3) (let ((archive x0) (elpa x2)) (progn (setq package-user-dir elpa) (elpa2nix-install-file archive))))))
emacs-lsp-origami>   (let* ((x0 (car-safe command-line-args-left)) (x1 (cdr-safe command-line-args-left))) (if (consp x1) (let* ((x2 (car-safe x1)) (x3 (cdr-safe x1))) (if (null x3) (let ((archive x0) (elpa x2)) (progn (setq package-user-dir elpa) (elpa2nix-install-file archive)))))))
emacs-lsp-origami>   (if (consp command-line-args-left) (let* ((x0 (car-safe command-line-args-left)) (x1 (cdr-safe command-line-args-left))) (if (consp x1) (let* ((x2 (car-safe x1)) (x3 (cdr-safe x1))) (if (null x3) (let ((archive x0) (elpa x2)) (progn (setq package-user-dir elpa) (elpa2nix-install-file archive))))))))
emacs-lsp-origami>   elpa2nix-install-package()
emacs-lsp-origami>   command-line-1(("-l" "/nix/store/0f21rid2as88mh6ghf6rpp1icr7fs1x7-elpa2nix.el" "-f" "elpa2nix-install-package" "/build/packages/lsp-origami-20230815.704.el" "/nix/store/x1iggzf256c280qp2964gsmgv1bnqsxw-emacs-lsp-origami-20230815.704/share/emacs/site-lisp/elpa"))
emacs-lsp-origami>   command-line()
emacs-lsp-origami>   normal-top-level()
emacs-lsp-origami> Invalid face box: :line-width, 1, :color, unspecified

[jcs090218]

I haven't started using Emacs 30, but I'll look into it!

Anyways, PRs are welcome! :D

[kurnevsky]

Looks like it's similar to doomemacs/themes#809 - emacs got stricter to invalid values inside box attribute :)