Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add int32s and int64s and uint32 and uint64 and float32 #177

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Luoxin
Copy link
Contributor

@Luoxin Luoxin commented Jun 23, 2022

No description provided.

@Luoxin Luoxin changed the title add int32s and int64s add int32s and int64s and uint32 and uint64 Jun 23, 2022
@Luoxin Luoxin changed the title add int32s and int64s and uint32 and uint64 add int32s and int64s and uint32 and uint64 and float32 Jun 23, 2022
@elliotchance
Copy link
Owner

Thanks for contributing, but I don't think I want to accept this change since it adds a lot of bloat to pie v1 and I would encourage anyone to upgrade to pie v2. Is there a reason that prevents you from using Go 1.18+?

@Luoxin
Copy link
Contributor Author

Luoxin commented Jun 27, 2022

The business upgrade to the GO version was not as fast because some internal calls using the system layer crashed after the upgrade to 1.18.  Maybe v2 and V1 should be supported at the same time

@elliotchance
Copy link
Owner

I do not want all this extra generated code to be committed for less common types. You can use pie to generate the types for your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants