Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consideration in generating options in Messages in OTP 26 #361

Open
slashmili opened this issue Nov 17, 2023 · 3 comments
Open

Consideration in generating options in Messages in OTP 26 #361

slashmili opened this issue Nov 17, 2023 · 3 comments
Assignees
@savhappy
Labels
Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work".

Comments

@slashmili
Copy link

Considering that options are map and in OTP 26 the order keys of map is not granted, should change it to keyword list?

alternatively Util.options_to_str and friends can run sort by key before join map_join?
@slashmili
Copy link
Author

Just in case it's not clear, this has side effect on the generated file, on every generation we get different file content because the options are generated in a different order.

@whatyouhide
Copy link
Collaborator

Yes this is a great callout!

alternatively Util.options_to_str and friends can run sort by key before join map_join?

Yes this is what we should do 👍

@whatyouhide whatyouhide added the Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work". label May 11, 2024
@whatyouhide
Copy link
Collaborator

cc @savhappy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savhappy savhappy

Labels
Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slashmili @whatyouhide @savhappy