Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any support unusable #360

Open
hassox opened this issue Oct 31, 2023 · 0 comments
Open

Any support unusable #360

hassox opened this issue Oct 31, 2023 · 0 comments
Labels
Kind:Improvement Improvement over the existing features, code refactors, and such.

Comments

@hassox
Copy link
Contributor

hassox commented Oct 31, 2023

Referring to: #329

Just wondering why the pack and unpack on the any protos was removed. #329 This change makes it very difficult to work with the any protos. There’s no longer any access to the fully qualified name from the generated code. You can’t access the package or the nesting to construct the type url.

Using the module name is insufficient since you can’t tell from the module name what is part of the package (lower case) and which are nested messages (CamelCase).

This change seems very strange. Every language I’ve ever used that supports any has a pack and unpack function or at the very least supports the package a message belongs to or the fully qualified name. Any insight on why this was removed without providing a way to access the information to work with these from the generated code?

The decision to remove the fully qualified name and pack and unpack makes working with any protos (specifically on the packing side) essentially impossible without writing a bunch of code specific to the modules that you are using. All that to replicate information that comes from the generation process :'(

@whatyouhide whatyouhide added the Kind:Improvement Improvement over the existing features, code refactors, and such. label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind:Improvement Improvement over the existing features, code refactors, and such.
Projects
None yet
Development

No branches or pull requests

2 participants