Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php variables #1

Open
darkhouse opened this issue Jan 16, 2013 · 1 comment
Open

php variables #1

darkhouse opened this issue Jan 16, 2013 · 1 comment

Comments

@darkhouse
Copy link

This scheme is very nice, I've been looking for an alternative to Twilight for quite a while and this one is finally one that I can actually code in... except for one thing. You made variables the same color as comments, and while it doesn't show up that color in languages like javascript and python, in php you end up with grey variables and grey comments. No easy way to discern between variables and comments at first glance. I changed variables to #006780 and that looks pretty good and seems to fit the overall scheme. I didn't bother submitting a pull request because I figure you might have a better idea for variable color, and I'd be interested in taking another look if you update the theme.

Thanks.

@eliquious
Copy link
Owner

Hey,

Glad you like it. I actually wrote it for myself as an alternate for
Twilight. You bring up a good point. I didn't test it with PHP so I
wouldn't know how it looks. I have used it for Python and Java though. Glad
you found the problem pretty early otherwise I may not have ever know as I
don't code in PHP. I'll check out the color you are using and then add it.
I'm sure what you are using looks fine though.

Thanks again.

On Wed, Jan 16, 2013 at 12:41 PM, darkhouse [email protected]:

This scheme is very nice, I've been looking for an alternative to Twilight
for quite a while and this one is finally one that I can actually code
in... except for one thing. You made variables the same color as comments,
and while it doesn't show up that color in languages like javascript and
python, in php you end up with grey variables and grey comments. No easy
way to discern between variables and comments at first glance. I changed
variables to #006780 and that looks pretty good and seems to fit the
overall scheme. I didn't bother submitting a pull request because I figure
you might have a better idea for variable color, and I'd be interested in
taking another look if you update the theme.

Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants