Skip to content

Commit 7b8156d

Browse files
committed
Find bar: use SVG generated bitmaps to generate hi-res images
1 parent bfa06d0 commit 7b8156d

22 files changed

+465
-42
lines changed

LiteEditor/quickfindbar.cpp

Lines changed: 24 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -88,35 +88,36 @@ QuickFindBar::QuickFindBar(wxWindow* parent, wxWindowID id)
8888
//-------------------------------------------------------------
8989
m_bar->SetExpandableColumn(5);
9090
GetSizer()->Add(m_bar, 1, wxEXPAND | wxALL, 2);
91-
QuickFindBarImages images;
9291

9392
// Add the 'close' button
94-
m_closeButton = m_bar->AddButton("", images.Bitmap("find-bar-close-16"), wxSize(24, -1));
93+
BitmapLoader* bmps = clGetManager()->GetStdIcons();
94+
95+
m_closeButton = m_bar->AddButton("", bmps->LoadBitmap("x-close"), wxSize(24, -1));
9596
m_closeButton->SetToolTip(_("Close"));
9697
m_closeButton->Bind(wxEVT_KEY_DOWN, &QuickFindBar::OnKeyDown, this);
9798
m_closeButton->Bind(wxEVT_CMD_FLATBUTTON_CLICK, &QuickFindBar::OnHideBar, this);
9899

99100
// Add the 'case sensitive' button
100-
m_caseSensitive = m_bar->AddButton("", images.Bitmap("case-sensitive"), wxSize(24, -1));
101+
m_caseSensitive = m_bar->AddButton("", bmps->LoadBitmap("case-sensitive"), wxSize(24, -1));
101102
m_caseSensitive->SetTogglable(true);
102103
m_caseSensitive->SetToolTip(_("Case sensitive match"));
103104
m_caseSensitive->Bind(wxEVT_KEY_DOWN, &QuickFindBar::OnKeyDown, this);
104105

105106
// Add the 'whole word' button
106-
m_wholeWord = m_bar->AddButton("", images.Bitmap("word"), wxSize(24, -1));
107+
m_wholeWord = m_bar->AddButton("", bmps->LoadBitmap("whole-word"), wxSize(24, -1));
107108
m_wholeWord->SetTogglable(true);
108109
m_wholeWord->SetToolTip(_("Match a whole word"));
109110
m_wholeWord->Bind(wxEVT_KEY_DOWN, &QuickFindBar::OnKeyDown, this);
110111

111-
m_regexOrWildButton = m_bar->AddButton("", images.Bitmap("regex"), wxSize(24, -1));
112+
m_regexOrWildButton = m_bar->AddButton("", bmps->LoadBitmap("regular-expression"), wxSize(24, -1));
112113
m_regexOrWildButton->SetTogglable(true);
113114
m_regexOrWildButton->Bind(wxEVT_CMD_FLATBUTTON_CLICK, &QuickFindBar::OnRegex, this);
114115
m_regexOrWildButton->Bind(wxEVT_UPDATE_UI, &QuickFindBar::OnRegexUI, this);
115116
m_regexOrWildButton->Bind(wxEVT_KEY_DOWN, &QuickFindBar::OnKeyDown, this);
116117
m_regexOrWildButton->SetToolTip(_("Use regular expression"));
117118

118119
// Marker button
119-
wxFlatButton* btnMarker = m_bar->AddButton("", images.Bitmap("marker-16"), wxSize(24, -1));
120+
wxFlatButton* btnMarker = m_bar->AddButton("", bmps->LoadBitmap("marker"), wxSize(24, -1));
120121
btnMarker->SetTogglable(true);
121122
btnMarker->Bind(wxEVT_CMD_FLATBUTTON_CLICK, &QuickFindBar::OnHighlightMatches, this);
122123
btnMarker->Bind(wxEVT_UPDATE_UI, &QuickFindBar::OnHighlightMatchesUI, this);
@@ -202,21 +203,12 @@ QuickFindBar::QuickFindBar(wxWindow* parent, wxWindowID id)
202203
GetSizer()->Fit(this);
203204
wxTheApp->Connect(
204205
XRCID("find_next"), wxEVT_COMMAND_MENU_SELECTED, wxCommandEventHandler(QuickFindBar::OnFindNext), NULL, this);
205-
wxTheApp->Connect(XRCID("find_previous"),
206-
wxEVT_COMMAND_MENU_SELECTED,
207-
wxCommandEventHandler(QuickFindBar::OnFindPrevious),
208-
NULL,
209-
this);
210-
wxTheApp->Connect(XRCID("find_next_at_caret"),
211-
wxEVT_COMMAND_MENU_SELECTED,
212-
wxCommandEventHandler(QuickFindBar::OnFindNextCaret),
213-
NULL,
214-
this);
215-
wxTheApp->Connect(XRCID("find_previous_at_caret"),
216-
wxEVT_COMMAND_MENU_SELECTED,
217-
wxCommandEventHandler(QuickFindBar::OnFindPreviousCaret),
218-
NULL,
219-
this);
206+
wxTheApp->Connect(XRCID("find_previous"), wxEVT_COMMAND_MENU_SELECTED,
207+
wxCommandEventHandler(QuickFindBar::OnFindPrevious), NULL, this);
208+
wxTheApp->Connect(XRCID("find_next_at_caret"), wxEVT_COMMAND_MENU_SELECTED,
209+
wxCommandEventHandler(QuickFindBar::OnFindNextCaret), NULL, this);
210+
wxTheApp->Connect(XRCID("find_previous_at_caret"), wxEVT_COMMAND_MENU_SELECTED,
211+
wxCommandEventHandler(QuickFindBar::OnFindPreviousCaret), NULL, this);
220212

221213
EventNotifier::Get()->Connect(
222214
wxEVT_FINDBAR_RELEASE_EDITOR, wxCommandEventHandler(QuickFindBar::OnReleaseEditor), NULL, this);
@@ -373,7 +365,7 @@ void QuickFindBar::OnKeyDown(wxKeyEvent& e)
373365
void QuickFindBar::OnUpdateUI(wxUpdateUIEvent& e)
374366
{
375367
e.Enable(ManagerST::Get()->IsShutdownInProgress() == false && m_sci && m_sci->GetLength() > 0 &&
376-
!m_findWhat->GetValue().IsEmpty());
368+
!m_findWhat->GetValue().IsEmpty());
377369
}
378370

379371
void QuickFindBar::OnEnter(wxCommandEvent& e)
@@ -471,12 +463,11 @@ void QuickFindBar::OnReplace(wxCommandEvent& event)
471463
DoSearch(kSearchForward);
472464
return;
473465
}
474-
466+
475467
// Ensure that the selection matches our search pattern
476468
size_t searchFlags = DoGetSearchFlags();
477-
if(m_sci->FindText(
478-
selStart, selEnd, searchFlags & wxSTC_FIND_REGEXP ? findWhatSciVersion : findwhat, searchFlags) ==
479-
wxNOT_FOUND) {
469+
if(m_sci->FindText(selStart, selEnd, searchFlags & wxSTC_FIND_REGEXP ? findWhatSciVersion : findwhat,
470+
searchFlags) == wxNOT_FOUND) {
480471
// we got a selection, but it does not match our search
481472
return;
482473
}
@@ -521,7 +512,7 @@ void QuickFindBar::OnReplace(wxCommandEvent& event)
521512
void QuickFindBar::OnReplaceUI(wxUpdateUIEvent& e)
522513
{
523514
e.Enable(ManagerST::Get()->IsShutdownInProgress() == false && m_sci && !m_sci->GetReadOnly() &&
524-
m_sci->GetLength() > 0 && !m_findWhat->GetValue().IsEmpty());
515+
m_sci->GetLength() > 0 && !m_findWhat->GetValue().IsEmpty());
525516
}
526517

527518
void QuickFindBar::OnReplaceEnter(wxCommandEvent& e)
@@ -807,21 +798,12 @@ QuickFindBar::~QuickFindBar()
807798
{
808799
wxTheApp->Disconnect(
809800
XRCID("find_next"), wxEVT_COMMAND_MENU_SELECTED, wxCommandEventHandler(QuickFindBar::OnFindNext), NULL, this);
810-
wxTheApp->Disconnect(XRCID("find_previous"),
811-
wxEVT_COMMAND_MENU_SELECTED,
812-
wxCommandEventHandler(QuickFindBar::OnFindPrevious),
813-
NULL,
814-
this);
815-
wxTheApp->Disconnect(XRCID("find_next_at_caret"),
816-
wxEVT_COMMAND_MENU_SELECTED,
817-
wxCommandEventHandler(QuickFindBar::OnFindNextCaret),
818-
NULL,
819-
this);
820-
wxTheApp->Disconnect(XRCID("find_previous_at_caret"),
821-
wxEVT_COMMAND_MENU_SELECTED,
822-
wxCommandEventHandler(QuickFindBar::OnFindPreviousCaret),
823-
NULL,
824-
this);
801+
wxTheApp->Disconnect(XRCID("find_previous"), wxEVT_COMMAND_MENU_SELECTED,
802+
wxCommandEventHandler(QuickFindBar::OnFindPrevious), NULL, this);
803+
wxTheApp->Disconnect(XRCID("find_next_at_caret"), wxEVT_COMMAND_MENU_SELECTED,
804+
wxCommandEventHandler(QuickFindBar::OnFindNextCaret), NULL, this);
805+
wxTheApp->Disconnect(XRCID("find_previous_at_caret"), wxEVT_COMMAND_MENU_SELECTED,
806+
wxCommandEventHandler(QuickFindBar::OnFindPreviousCaret), NULL, this);
825807
EventNotifier::Get()->Disconnect(
826808
wxEVT_FINDBAR_RELEASE_EDITOR, wxCommandEventHandler(QuickFindBar::OnReleaseEditor), NULL, this);
827809
}

Runtime/codelite-bitmaps.zip

7.64 KB
Binary file not shown.

bitmaps/16-case-sensitive.png

550 Bytes
Loading

bitmaps/[email protected]

1.14 KB
Loading
488 Bytes
Loading

bitmaps/[email protected]

546 Bytes
Loading

bitmaps/16-marker.png

427 Bytes
Loading

bitmaps/[email protected]

720 Bytes
Loading

bitmaps/16-regular-expression.png

380 Bytes
Loading

bitmaps/[email protected]

766 Bytes
Loading

0 commit comments

Comments
 (0)