Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disablement flag for uploading test results #302

Closed
Maayan-s opened this issue Sep 4, 2022 · 4 comments
Closed

Add disablement flag for uploading test results #302

Maayan-s opened this issue Sep 4, 2022 · 4 comments

Comments

@Maayan-s
Copy link
Contributor

Maayan-s commented Sep 4, 2022

The test results upload happens on an on-run-end.
Users should have a way to disable it in a specific run using a var.

@jakubvedral
Copy link

jakubvedral commented Sep 8, 2022

+1
There should be a way to temporarily disable elementary on-run-start and on-run-end hook using a var.

For example by modifying dbt_project.yml (thats our current hack):

on-run-start:
  - "{%- if var('use_elementary', default=false) -%} {{ elementary.create_elementary_tests_schema() if flags.WHICH in ['test', 'build'] }} {%- endif -%}"
on-run-end:
  - "{%- if var('use_elementary', default=false) -%} {{ elementary.handle_tests_results(results) if flags.WHICH in ['test', 'build'] }} {%- endif -%}"
  - "{%- if var('use_elementary', default=false) -%} {{ elementary.upload_run_results(results) }} {%- endif -%}"

@elongl
Copy link
Member

elongl commented Nov 29, 2022

Introduced a var called disable_tests_results.

@elongl elongl closed this as completed Nov 29, 2022
@DakotaMichael
Copy link

Is there anything like this that would be model-specific? For instance if we wanted not to upload particularly wide models from uploading the test_results_query, would this be possible for said models?

@elongl
Copy link
Member

elongl commented Jul 10, 2024

Hi @DakotaMichael, could you perhaps elaborate a bit on the use-case or the problem you're trying to solve? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants