hookshot being enabled seems to break everything

[halkeye]

Describe the bug
Synapse no longer starts up because its trying to access the registration secret, but doesn't seem to actually mount the secret
Hookshot itself doesn't startup because it seems to try and mount a secret that doesn't exist?

To Reproduce

hookshot:
  enabled: true
  annotations:
    reloader.stakater.com/auto: 'true'
  appserviceRegistration:
    secret: matrix-stack-hookshot-2
    secretKey: hookshot_registration.yaml
  passkey:
    secret: matrix-stack-hookshot-2
    secretKey: hookshot_passkey
  additional:
    permissions.yaml:
      configSecret: matrix-stack-hookshot-2
      configSecretKey: permissions.yaml

Expected behavior
Starts up

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[gaelgatelement]

Hello,

Did you generate the registration file? Or do you expect the chart to generate it for you?

If you expect the chart to generate it, you should not pass the secrets explicitly in the chart values.

[halkeye]

I used https://github.com/matrix-org/matrix-hookshot/blob/main/registration.sample.yml as a template and created my own registration and added it to the secret matrix-stack-hookshot-2 and the key hookshot_registration.yaml

synapse had it added to its appservice array, but didn't actually volumeMount that secret, so the file was not found

maybe it would work if it was a secret that synapse was already loading but since its a required field for hookshot i put it in the hookshot secret.

[halkeye]

ess-helm/charts/matrix-stack/templates/synapse/_helpers.tpl

Lines 274 to 285 in 869ce4f

	{{- if $root.Values.hookshot.enabled -}}
	{{- $appservicesFiles = append $appservicesFiles (printf "/secrets/%s"
	(include "element-io.ess-library.init-secret-path" (
	dict "root" $root
	"context" (dict
	"secretPath" "hookshot.appserviceRegistration"
	"initSecretKey" "HOOKSHOT_REGISTRATION"
	"defaultSecretName" (include "element-io.hookshot.secret-name" (dict "root" $root "context" (dict "isHook" $isHook)))
	"defaultSecretKey" "REGISTRATION"
	)
	))) -}}
	{{- end -}}

is where it gets added to synapse
but i don't see any reference to it when crafting volume mounts (but i don't fully understand the isHook stuff)