Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codesigning works on M* Mac but not on Intel Mac #3563

Open
3 tasks done
drixie opened this issue Apr 12, 2024 · 2 comments
Open
3 tasks done

Codesigning works on M* Mac but not on Intel Mac #3563

drixie opened this issue Apr 12, 2024 · 2 comments
Labels
blocked/needs-repro Issues unable to be reproduced by maintainers

Comments

@drixie
Copy link

drixie commented Apr 12, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.0.5

Electron version

24.8.6

Operating system

macOS 12.2.1

Last known working Electron Forge version

No response

Expected behavior

Signed and notarized builds generated for both M1 Mac and Intel Mac

Actual behavior

Build is signed and notarized for M1 Mac. Build fails on Intel Mac with a error code related to notarization. Further investigation revealed that this is because codesigning never happened. I never received an error about this. I noticed after disabling the notarization config and running "codesign -dvvv" on the generated build. I am using the same signing certificates and same electron forge configs on both machines

Steps to reproduce

Try to generate, codesign, and notarize a build on both M* and Intel Macs using the same signing certificate

Additional information

Just wanting to know if some has experienced something similar before and what they did to resolve it

@drixie
Copy link
Author

drixie commented Apr 12, 2024

On the Intel Mac, I noticed it never asks this question which it asks on the M1 Mac.

codesign wants to access key "Mac Developer ID Application: {Developer name}" in your keychain

This might be the failure point. I noticed the question came up when using electron-builder which successfully signed the app on the Intel Mac (confirmed with codesign -dvvv) but the app is broken (something to do with the resolution of internal file paths I presume)

Perhaps there's a config setting that should ensure this question comes up or the request is automatically allowed?

@VerteDinde VerteDinde added the blocked/needs-repro Issues unable to be reproduced by maintainers label Apr 18, 2024
@VerteDinde
Copy link
Member

@drixie Does this behavior reproduce with the default Forge app? I wasn't able to repro on an Intel environment with the default app, trying to get a better understanding of what might be failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-repro Issues unable to be reproduced by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants