Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphens ('1.0.1-0') not a valid version string when building on @electron-forge/maker-squirrel #3533

Open
3 tasks done
gabriel-cloud opened this issue Mar 13, 2024 · 0 comments

Comments

@gabriel-cloud
Copy link

gabriel-cloud commented Mar 13, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.3.0

Electron version

v29.1.2

Operating system

Windows 11 23h2

Last known working Electron Forge version

n/a

Expected behavior

Build would be successful using hyphenated version numbers created by npm version prerelease

Actual behavior

An unhandled rejection has occurred inside Forge:
Error: Failed with exit code: 1
Output:
Attempting to build package from 'my_app.nuspec'.
'1.0.1-0' is not a valid version string.
Parameter name: version
at ChildProcess.<anonymous> (D:\dev\versionNumber\my-app\node_modules\electron-winstaller\lib\spawn-promise.js:48:24)
    at ChildProcess.emit (node:events:514:28)
    at ChildProcess.emit (node:domain:488:12)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Steps to reproduce

  1. Open a folder
  2. npm init electron-app@latest my-app
  3. cd my-app
  4. npm version prerelease
  5. ✅ Observe the version is now 1.0.0-0
  6. npm run make
  7. ❌ Observe you get an unhandled exception
  8. This only seems to affect @electron-forge/maker-squirrel . I can build just fine on macOS using @electron-forge/maker-zip
An unhandled rejection has occurred inside Forge:
Error: Failed with exit code: 1
Output:
Attempting to build package from 'my_app.nuspec'.
'1.0.1-0' is not a valid version string.
Parameter name: version
at ChildProcess.<anonymous> (D:\dev\versionNumber\my-app\node_modules\electron-winstaller\lib\spawn-promise.js:48:24)
    at ChildProcess.emit (node:events:514:28)
    at ChildProcess.emit (node:domain:488:12)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Additional information

No response

@erickzhao erickzhao added maker/squirrel platform/windows bug blocked/upstream Issues blocked by upstream bugs and removed blocked/upstream Issues blocked by upstream bugs labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants