Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The exe becoming double the size even after updating electron-json-storage to 4.1.2 #118

Open
GorvGoyl opened this issue Sep 23, 2018 · 1 comment

Comments

@GorvGoyl
Copy link

GorvGoyl commented Sep 23, 2018

I looked into the issue #114 but my electron app is still doubling the size.
w/o electron-json-storage: 35 mb
w/ electron-json-storage: 71mb

"electron": "^2.0.10",
"electron-json-storage": "^4.1.2",
"electron-builder": "^19.56.2"

also see result of npm prune:

> npm prune --production
> npm WARN [email protected] requires a peer of electron@^2.0.4 but none is installed. You must install peer dependencies yourself.

Update: issue exist when I used npm, when I used yarn then it indicated that some other modules were needed to update to resolve peerdependency of electron with electron-json-storage.
After updating modules in package.json it seems to work fine now.
lesson learned: do not use npm, use yarn :P

@bingqiao
Copy link

This could be related to:
#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants