Skip to content

Commit

Permalink
feat(appx): update validCharactersRegex in applicationid
Browse files Browse the repository at this point in the history
  • Loading branch information
ifurther committed May 15, 2024
1 parent b6f2499 commit 1358d71
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/app-builder-lib/src/targets/AppxTarget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ export default class AppXTarget extends Target {

case "applicationId": {
const result = options.applicationId || options.identityName || appInfo.name
const validCharactersRegex = /^[a-zA-Z0-9.-]+$/
const identitynumber = parseInt(result, 10)
const validCharactersRegex = /^([A-Za-z][A-Za-z0-9]*)(\.[A-Za-z][A-Za-z0-9]*)*$/
const identitynumber = parseInt(result, 10)
if (!isNaN(identitynumber)) {
log.warn(`Remove the ${identitynumber}`)
result = result.replace(identitynumber,'')

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura...

Cannot assign to 'result' because it is a constant.

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura...

No overload matches this call.

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-updater

Cannot assign to 'result' because it is a constant.

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-updater

No overload matches this call.

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-mac

Cannot assign to 'result' because it is a constant.

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-mac

No overload matches this call.

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-windows (winCodeSignTest,differentialUpdateTest)

Cannot assign to 'result' because it is a constant.

Check failure on line 232 in packages/app-builder-lib/src/targets/AppxTarget.ts

View workflow job for this annotation

GitHub Actions / test-windows (winCodeSignTest,differentialUpdateTest)

No overload matches this call.
Expand Down

0 comments on commit 1358d71

Please sign in to comment.