Skip to content

Commit

Permalink
fix notarization: use APPLE_APP_SPECIFIC_PASSWORD instead of APPLE_ID…
Browse files Browse the repository at this point in the history
…_PASS for authentication (#3491)
  • Loading branch information
nsrCodes committed Sep 16, 2023
1 parent 8d3efc1 commit 43d7ba5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .erb/scripts/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ exports.default = async function notarizeMacos(context) {
return;
}

if (!('APPLE_ID' in process.env && 'APPLE_ID_PASS' in process.env)) {
if (!('APPLE_ID' in process.env && 'APPLE_APP_SPECIFIC_PASSWORD' in process.env)) {

Check failure on line 15 in .erb/scripts/notarize.js

View workflow job for this annotation

GitHub Actions / test (ubuntu-latest)

Replace `!('APPLE_ID'·in·process.env·&&·'APPLE_APP_SPECIFIC_PASSWORD'·in·process.env)` with `⏎····!('APPLE_ID'·in·process.env·&&·'APPLE_APP_SPECIFIC_PASSWORD'·in·process.env)⏎··`
console.warn(
'Skipping notarizing step. APPLE_ID and APPLE_ID_PASS env variables must be set'
'Skipping notarizing step. APPLE_ID and APPLE_APP_SPECIFIC_PASSWORD env variables must be set'
);
return;
}
Expand All @@ -25,6 +25,6 @@ exports.default = async function notarizeMacos(context) {
appBundleId: build.appId,
appPath: `${appOutDir}/${appName}.app`,
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_ID_PASS,
appleIdPassword: process.env.APPLE_APP_SPECIFIC_PASSWORD,
});
};

0 comments on commit 43d7ba5

Please sign in to comment.