Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Are isRunning / isRestored properties necessary? #183964

Open
thomasneirynck opened this issue May 21, 2024 · 2 comments
Open

[Search] Are isRunning / isRestored properties necessary? #183964

thomasneirynck opened this issue May 21, 2024 · 2 comments
Assignees
Labels
chore loe:small Small Level of Effort performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@thomasneirynck
Copy link
Contributor

Kibana version:

8.15/main

Description

When a search has not completed, the polling result of an async searches always include following properties:

{
  "id": "FnBTVzZRVkpZUjI2dVluN2RCQ2RwbFEdN0huQmtVZ1BUYmlISU9QQ0Rza0lMQTo4ODU0Mzg=",
  "rawResponse": {},
  "isPartial": true,
  "isRunning": true,
  "isRestored": true
}

It does not seem we are using isRunning and isRestored on the client (ie. in the browser). Is this a correct reading?

If so, we should remove. With the removal of bsearch, we are generating more of these polls and a good chunk of the response does not seem necessary. The values are flagged as optionally already (

/**
* Indicates whether the results returned are complete or partial
*/
isPartial?: boolean;
/**
* Indicates whether the results returned are from the async-search index
*/
isRestored?: boolean;
).

@thomasneirynck thomasneirynck added chore Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels May 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed triage_needed labels Jul 8, 2024
@thomasneirynck thomasneirynck changed the title [Search] Can we remove isRunning / isRestored properties necessary? [Search] Are isRunning / isRestored properties necessary? Jul 30, 2024
@thomasneirynck thomasneirynck removed the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 12, 2025
@thomasneirynck
Copy link
Contributor Author

discussed with @lukasolson . nice to have, but anticipate low impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore loe:small Small Level of Effort performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants