Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Cursors are still syncing across panels even though the setting is turned off #183454

Closed
bhavyarm opened this issue May 14, 2024 · 3 comments · Fixed by #184129
Closed

[Dashboard] Cursors are still syncing across panels even though the setting is turned off #183454

bhavyarm opened this issue May 14, 2024 · 3 comments · Fixed by #184129
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
Dashboard

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.14.0 BC4

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from. staging

Describe the bug: Cursors are still syncing across the panel even the setting turned off.

Screenshot 2024-05-14 at 7 05 01 PM
cursor.mp4
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels May 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels May 14, 2024
@kibanamachine kibanamachine added this to Inbox in Dashboard May 14, 2024
@nreese
Copy link
Contributor

nreese commented May 23, 2024

also occurs in 8.13.4 and is not related to embeddable rebuild. syncCursor is not getting passed to panel input in DashboardContainer.getInheritedInput. This has been occuring since at least 8.7.0

@nreese nreese added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated labels May 23, 2024
@nreese nreese mentioned this issue May 23, 2024
Merged
@nreese
Copy link
Contributor

nreese commented May 23, 2024

putting impact as low considering its been broken for at least a year and a half and there have not been any issues created. Fixing since effort is small compared to the effort to figure out the problem.

nreese added a commit that referenced this issue May 23, 2024
@nreese
[dashboard] fix Cursors are still syncing across panels even though t…
2899fae 
…he setting is turned off (#184129)

Closes #183454

Problem is resolved by passing `syncCursor` state from dashboard input
to panel input.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 23, 2024
@nreese
[dashboard] fix Cursors are still syncing across panels even though t…
d2ef18e 
…he setting is turned off (elastic#184129)

Closes elastic#183454

Problem is resolved by passing `syncCursor` state from dashboard input
to panel input.

(cherry picked from commit 2899fae)
kibanamachine added a commit that referenced this issue May 23, 2024
@kibanamachine @nreese
[8.14] [dashboard] fix Cursors are still syncing across panels even t…
abeedb1 
…hough the setting is turned off (#184129) (#184152)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[dashboard] fix Cursors are still syncing across panels even though
the setting is turned off
(#184129)](#184129)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-23T16:15:20Z","message":"[dashboard]
fix Cursors are still syncing across panels even though the setting is
turned off (#184129)\n\nCloses
#183454 is
resolved by passing `syncCursor` state from dashboard input\r\nto panel
input.","sha":"2899faeb2ac78b843865da79e5d685ee44123263","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:small","impact:low","v8.14.0","v8.15.0"],"title":"[dashboard]
fix Cursors are still syncing across panels even though the setting is
turned
off","number":184129,"url":"#184129
fix Cursors are still syncing across panels even though the setting is
turned off (#184129)\n\nCloses
#183454 is
resolved by passing `syncCursor` state from dashboard input\r\nto panel
input.","sha":"2899faeb2ac78b843865da79e5d685ee44123263"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#184129
fix Cursors are still syncing across panels even though the setting is
turned off (#184129)\n\nCloses
#183454 is
resolved by passing `syncCursor` state from dashboard input\r\nto panel
input.","sha":"2899faeb2ac78b843865da79e5d685ee44123263"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
No open projects
Dashboard
  
Inbox
Milestone
No milestone
4 participants
@nreese @bhavyarm @elasticmachine @kibanamachine