[ResponseOps][Alerts] Fix stack alerts page table loading twice when filters load #183405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
umbopepato
force-pushed
the
stack-alerts-page-double-loading-fix
branch
from
03c84a6
to
0a3ab92
Compare
|
/ci |
umbopepato
changed the title
umbopepato
added
release_note:fix
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
I am not sure it is fixed @umbopepato 😞 If I am in But if I am anywhere else and navigate to bug.mov |
adcoelho
reviewed
May 15, 2024
| @@ -50,9 +59,11 @@ describe('StackAlertsPage', () => { | |||
|
|
|||
There was a problem hiding this comment.
I'd replace this whole block by:
appMockRender.render(<StackAlertsPage />);
expect(await screen.findByTestId('stackAlertsPageContent')).toBeInTheDocument();
expect(await screen.findByTestId('urlSyncedAlertsSearchBar')).toBeInTheDocument();
expect(await screen.findByTestId('alertsTable')).toBeInTheDocument()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Waits for the filter controls bar to load before triggering the alerts table loading.
Fixes #183412
To verify
Fetch/XHRand searchbsearchStack Management>Alerts)bsearchnetwork request is performed